Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add quick open/input color registers #74041

Merged
merged 1 commit into from
Jun 24, 2019
Merged

add quick open/input color registers #74041

merged 1 commit into from
Jun 24, 2019

Conversation

chaseadamsio
Copy link
Contributor

@chaseadamsio chaseadamsio commented May 21, 2019

The goal of this PR is to extract the color registration for the quick opener/quick input so that it can be styled separately from the Sidebar.

Currently, it's pulling whatever styles are create on the sidebar for foreground and background. This isn't intuitive for theme developers (personally, I struggled to remember which register to use and I only figured it out because of others having the same experience and discussing on Stack Overflow). It's also limiting in that it forces theme developers into making a decision about both the sidebar and the quick picker.

I want to propose registering two new color selectors:

  • "quickOpen.background"
  • "quickOpen.foreground"

Here's an example after running ./scripts/code.sh on master and the PR branch.

Before (master):
image

After (freeQuickPickerColors, in my theme I set the background color to a darker black fo the "quickOpen.background" and left "sideBar.background" the same):
image

@aeschli aeschli assigned chrmarti and unassigned aeschli May 23, 2019
@aeschli
Copy link
Contributor

aeschli commented May 23, 2019

The changes make sense to me, but assigning to @chrmarti as he's the owner of the (various) quick pick UIs

@chaseadamsio
Copy link
Contributor Author

Hey @alexr00, any chance you've been able to mull this over? If you have any questions / suggestions I'm open to them!

@chrmarti chrmarti merged commit 9e02832 into microsoft:master Jun 24, 2019
@chrmarti
Copy link
Contributor

Thanks @chaseadamsio !

@craigcosmo
Copy link

craigcosmo commented Jul 23, 2019

it's not working. "quickOpen.background":"#fff" doesn't make my picker white.

@chaseadamsio
Copy link
Contributor Author

Looks like there was a commit here: cc6b5c3 where quickOpen was replaced with quickInput and was mentioned in this comment. but not updated here.

For reference, for anyone who finds this in the future, the following:

"quickOpen.background"
"quickOpen.foreground"

has been replaced with:

"quickInput.background"
"quickInput.foreground"

@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants