Add folding from end of region

[zbecknell]

This is a simple to understand enhancement: allow folding code from the end of a region. A gif is worth a thousand words, so here's what it looks like in action:

High-level details on the implementation:

• Disabled by default
• When region ends intersect, the outer-most region is collapsed on click
• As you can see I chose to de-emphasize the end fold icon a bit

I hope you will consider pulling in this change, as I quite like being able to fold up a large region when I'm at its end to give a better idea of context around it. If you don't want to implement this or some form of it, I've at least enjoyed playing around in the code a bit. It was a nice night of fun.

[msftclas]

All CLA requirements met.

[FastestMolasses]

I really like this idea, I hope it's implemented.

[aeschli]

Great stuff.
I want to talk to @alexandrudima if we find a possibility to do this with a single decoration

[ilayofir]

It would also be nice to be able to fold from the bottom at the explorer window, since directories like node_modules might get very big

[seelts]

2022...

[1muen]

@ilayofir

It would also be nice to be able to fold from the bottom at the explorer window, since directories like node_modules might get very big

If the node_modules folder opens because I clicked on Show Definition on a module, I close the large node_modules folder structure by clicking on any file or folder in there and press the left arrow key, so the tree structure shrinks.

[adrm]

Could this be at least shipped as an extension? I understand the team might have its doubts about how to implement this in a consistent manner, but it will be useful immediately if it can be used as an extension.

[WayneWuQSR]

This is a feature I'm after now. Is there any development on this? Or is there any extension can do the same thing?

[zbecknell]

This PR is of course old as the hills now and probably needs to be almost entirely rewritten (just an assumption). If there is a desire from maintainers to really include this I could crack the code back open and try to update it with the latest codebase.

[KaKi87]

Hi,

If there is a desire from maintainers to really include this

Since it doesn't look like this is going to happen, would you consider checking whether this would be doable as an extension, and if yes, would you consider building it as one instead ?

Thanks

[aeschli]

Closing the PR as there hasn't been any progress for multiple years. It's easier to start with a fresh PR.

If someone is interested, I would suggest to check out:

vscode/src/vs/editor/common/model.ts

Line 236 in 2a5bd3e

firstLineDecorationClassName?: string | null;

This is used to render the folding indicator.

I would suggest adding a lastLineDecorationClassName that can be used for the end indicator.

[KaKi87]

😭

[zbecknell]

The end of an era 🤓

[KaKi87]

VSCode needs a fork that is community-centered.