Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setting in product.json for customDataDirectory #828

Closed
wants to merge 1 commit into from

Conversation

DickvdBrink
Copy link
Contributor

This setting allows the user to provide a custom directory for extensions, snippets and settings.
This is the first step for making vscode a portable application.

refs #329

Feedback appreciated, feel free to close though :)

Note: Not there is still some stuff in the %appdata% directory; the LocalStorage, GPUCache, DevTools Extensions and a electron settings file

This setting allows the user to provide a custom directory for extensions, snippets and settings.
This is the first step for making vscode a portable application
@msftclas
Copy link

Hi @DickvdBrink, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by Microsoft and real humans are currently evaluating your PR.

TTYL, MSBOT;

@bpasero
Copy link
Member

bpasero commented Dec 1, 2015

@DickvdBrink thanks, this is however not enough. You will need to set the data directory very early, see https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/electron-main/bootstrap.js#L24 for an example how we set it for development.

I think we should check what Atom is doing here for being portable (atom/atom#2939) and do something similar. At the very minimum, there should be a command line argument to set the data location and extensions location. Currently they are split but at some point we want to merge them into one. I would also think a good fallback is to put the directories next to code.exe if you run with something like "--portable".

@bpasero bpasero self-assigned this Dec 1, 2015
@DickvdBrink DickvdBrink closed this Dec 1, 2015
@stkb stkb mentioned this pull request Apr 12, 2018
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants