Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename splitview panels to panes #85166

Merged
merged 3 commits into from
Nov 20, 2019
Merged

Conversation

sbatten
Copy link
Member

@sbatten sbatten commented Nov 20, 2019

Refs #85164

1st commit does symbol renaming and updates css values
2nd commit renames files to avoid confusion

@sbatten sbatten added this to the November 2019 milestone Nov 20, 2019
@sbatten sbatten self-assigned this Nov 20, 2019
@isidorn
Copy link
Contributor

isidorn commented Nov 20, 2019

Great changes! Approved.
You just missed one place
https://github.com/Microsoft/vscode/blob/65050271c24788f74456cc9210931dbecf9c79c5/src/vs/workbench/browser/parts/views/customView.ts#L46
CustomTreeViewPanel should be CustomTreeViewPane

Love this
Screenshot 2019-11-20 at 10 57 57

@joaomoreno
Copy link
Member

joaomoreno commented Nov 20, 2019

@isidorn

This is still true in master, even without this PR:

Screenshot 2019-11-20 at 10 57 57

The splitview never knew anything about panels.

@isidorn
Copy link
Contributor

isidorn commented Nov 20, 2019

@joaomoreno ok. My bad. However I also checked full text search in other areas and it looks much better

@sandy081
Copy link
Member

👏 ✅

@sbatten sbatten merged commit 8eaf2a3 into microsoft:master Nov 20, 2019
@sbatten sbatten deleted the viewletRefactor branch November 20, 2019 18:59
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants