-
Notifications
You must be signed in to change notification settings - Fork 29.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support ViewPaneContainer in Panel #87191
Conversation
src/vs/workbench/browser/panel.ts
Outdated
|
||
export abstract class Panel extends Composite implements IPanel { } | ||
|
||
export abstract class PanelV2 extends PaneComposite implements IPanel { } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about calling this PaneCompositePanel
?
@@ -344,7 +345,8 @@ export class ViewPaneContainer extends Component implements IViewPaneContainer { | |||
} | |||
|
|||
getTitle(): string { | |||
let title = Registry.as<ViewletRegistry>(Extensions.Viewlets).getViewlet(this.getId()).name; | |||
const composite = Registry.as<ViewletRegistry>(ViewletExtensions.Viewlets).getViewlet(this.getId()) || Registry.as<PanelRegistry>(PanelExtensions.Panels).getPanel(this.getId()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like ViewContainer
should support name
property. Can you please create a follow up item for this?
Few comments as mentioned above, otherwise LGTM. Please merge it after above feedback is taken care of. |
No description provided.