fix: use correct codicon names for folding control colour customisation #97091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertrossmann
added a commit
to robertrossmann/vscode-remedy
that referenced
this pull request
May 6, 2020
The foreground colour seems to be broken currently. See microsoft/vscode#97091
github-actions bot
pushed a commit
to robertrossmann/vscode-remedy
that referenced
this pull request
May 6, 2020
# [4.13.0](4.12.0...4.13.0) (2020-05-06) ### Bug Fixes * improve menu contrast by adding a border ([dd60676](dd60676)) ### Features * add Slack colour palette 😂 🤷♂️ ([8764188](8764188)) * customise folded line highlights and folding chevrons/buttons ([5e5a4a1](5e5a4a1)), closes [microsoft/vscode#97091](microsoft/vscode#97091) * customise invalid list items' foreground 🤷♂️ ([98d9e40](98d9e40)) * improve consistency of focus foregrounds on tabs and breadcrumbs ([7f6a57a](7f6a57a))
IllusionMH
reviewed
May 7, 2020
|
The PR goes in the wrong direction. The purpose of my change was to introduce new icon names ('folding-expanded','folding-collapsed') so that these can be themed individually by a product icon theme. So keep const foldingExpandedIcon = registerIcon('folding-expanded', Codicon.chevronDown); and use |
|
Thanks @aeschli for explanation - I pushed an updated version following your suggested approach. ✅ |
|
Perfect, thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the
editorGutter.foldingControlForegroundcolour contribution point by using the correct codicon names in the CSS.Not sure when this regressed, I just noticed this while playing around with colour contributions and did not see any effect when I customised it.