-
Notifications
You must be signed in to change notification settings - Fork 29.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement colour contributions for debug REPL #97762
Conversation
@robertrossmann great PR as usual! Thanks a lot 👏
|
Thanks for pushing this. Would be great to eventually have all of debug be fully themable 👍 |
@isidorn Thanks for the suggestions! I will drop I'll rename the colour scope to |
@isidorn updated now, with some deviations noted below. ℹ️
Let me know what you think. ❤️ |
Thanks a lot. Your changes look great thus approving. Though let's wait just for @aeschli to approve the color names and then we can merge this. |
@robertrossmann after discussing with @aeschli we like all the color names except |
@isidorn Updated! ✅ |
Looks great. Thanks for doing this. Merging in 🎉 |
# [4.14.0](4.13.0...4.14.0) (2020-05-18) ### Features * add debug Console colour contributions 🎨 ([9cd02be](9cd02be)), closes [microsoft/vscode#97762](microsoft/vscode#97762) * customise colours for Test Explorer UI 🎨 ([0d0568f](0d0568f)), closes [hbenl/vscode-test-explorer#132](hbenl/vscode-test-explorer#132)
This PR fixes #97695.
Most of the debug REPL components are now theme-able. 🎉 🎨 The following new colour contributions have been added:
debugConsole.infoForeground
: info-level messagesdebugConsole.warningForeground
: warning-level messagesdebugConsole.errorForeground
: error-level messagesdebugConsole.sourceForeground
: foreground colour of the source filename which generated the log messagedebugConsoleInputIcon.foreground
: icon colour which marks the evaluation input. I remember seeing a very specific name for this icon but I cannot remember. I will happily update the naming of this contribution to match if this is not accurate.Chores
I have moved the theming support for REPL out of the
repl.ts
file so we have it in one place.