Mark early testhost startup APIs as internal for TP 16.9 (#2768)

* Marked test session APIs as internal * Changed branding to 16.9.1 and updated CC externals Co-authored-by: Codrin Poienaru <copoiena@microsoft.com>
microsoft · Feb 23, 2021 · 6a858a3 · 6a858a3
1 parent 27786c2
commit 6a858a3
Show file tree

Hide file tree

Showing 8 changed files with 286 additions and 286 deletions.
diff --git a/scripts/build/TestPlatform.Dependencies.props b/scripts/build/TestPlatform.Dependencies.props
@@ -11,7 +11,7 @@
     <!-- this version also needs to be "statically" readable because the test fixture will inspect this file for the version 
     and because during the test `dotnet test` will run and re-build some of the test projects and at that time the version 
     from a build parameter would not be available, so I am writing this version from the build.ps1 script to keep it in sync -->
-    <NETTestSdkVersion>16.9.0-dev</NETTestSdkVersion>
+    <NETTestSdkVersion>16.9.1-dev</NETTestSdkVersion>
 
     <MSTestFrameworkVersion>2.1.0</MSTestFrameworkVersion>
     <MSTestAdapterVersion>2.1.0</MSTestAdapterVersion>
@@ -32,7 +32,7 @@
     <JsonNetVersion>9.0.1</JsonNetVersion>
     <MoqVersion>4.7.63</MoqVersion>
     <TestPlatformExternalsVersion>16.9.0-preview-4267359</TestPlatformExternalsVersion>
-    <CodeCoverageExternalsVersion>16.9.0-beta.21105.3</CodeCoverageExternalsVersion>
+    <CodeCoverageExternalsVersion>16.9.0-beta.21119.4</CodeCoverageExternalsVersion>
     <MicrosoftFakesVersion>16.9.0-beta.20628.1</MicrosoftFakesVersion>
 
     <MicrosoftBuildPackageVersion>16.0.461</MicrosoftBuildPackageVersion>

diff --git a/scripts/build/TestPlatform.Settings.targets b/scripts/build/TestPlatform.Settings.targets
@@ -5,7 +5,7 @@
     <!-- This version is read by vsts-prebuild.ps1 and is a base for the current version, this should be updated
     at the start of new iteration to the goal number. This is also used to version the local packages. This version needs to be statically
     readable when we read the file as xml, don't move it to a .props file, unless you change the build server process -->
-    <TPVersionPrefix>16.9.0</TPVersionPrefix>
+    <TPVersionPrefix>16.9.1</TPVersionPrefix>
   </PropertyGroup>
   <PropertyGroup>
     <!-- Versioning is defined from the build script. Use a default dev build if it's not defined.

diff --git a/src/Microsoft.TestPlatform.VsTestConsole.TranslationLayer/Interfaces/ITestSession.cs b/src/Microsoft.TestPlatform.VsTestConsole.TranslationLayer/Interfaces/ITestSession.cs
@@ -13,7 +13,7 @@ namespace Microsoft.VisualStudio.TestPlatform.VsTestConsole.TranslationLayer.Int
     /// Defines a test session that can be used to make calls to the vstest.console
     /// process.
     /// </summary>
-    public interface ITestSession : ITestSessionAsync
+    internal interface ITestSession : ITestSessionAsync
     {
         /// <summary>
         /// Starts test discovery.

diff --git a/src/Microsoft.TestPlatform.VsTestConsole.TranslationLayer/Interfaces/ITestSessionAsync.cs b/src/Microsoft.TestPlatform.VsTestConsole.TranslationLayer/Interfaces/ITestSessionAsync.cs
@@ -13,7 +13,7 @@ namespace Microsoft.VisualStudio.TestPlatform.VsTestConsole.TranslationLayer.Int
     /// Defines a test session that can be used to make async calls to the vstest.console
     /// process.
     /// </summary>
-    public interface ITestSessionAsync
+    internal interface ITestSessionAsync
     {
         /// <summary>
         /// Starts test discovery.

diff --git a/...Microsoft.TestPlatform.VsTestConsole.TranslationLayer/Interfaces/IVsTestConsoleWrapper.cs b/...Microsoft.TestPlatform.VsTestConsole.TranslationLayer/Interfaces/IVsTestConsoleWrapper.cs
@@ -53,21 +53,21 @@ void DiscoverTests(
             TestPlatformOptions options,
             ITestDiscoveryEventsHandler2 discoveryEventsHandler);
 
-        /// <summary>
-        /// Starts test discovery.
-        /// </summary>
-        /// 
-        /// <param name="sources">The list of source assemblies for the discovery.</param>
-        /// <param name="discoverySettings">The run settings for the discovery.</param>
-        /// <param name="options">The test platform options.</param>
-        /// <param name="testSessionInfo">The test session info object.</param>
-        /// <param name="discoveryEventsHandler">The discovery event handler.</param>
-        void DiscoverTests(
-            IEnumerable<string> sources,
-            string discoverySettings,
-            TestPlatformOptions options,
-            TestSessionInfo testSessionInfo,
-            ITestDiscoveryEventsHandler2 discoveryEventsHandler);
+        // <summary>
+        // Starts test discovery.
+        // </summary>
+        // 
+        // <param name="sources">The list of source assemblies for the discovery.</param>
+        // <param name="discoverySettings">The run settings for the discovery.</param>
+        // <param name="options">The test platform options.</param>
+        // <param name="testSessionInfo">The test session info object.</param>
+        // <param name="discoveryEventsHandler">The discovery event handler.</param>
+        // void DiscoverTests(
+        //     IEnumerable<string> sources,
+        //     string discoverySettings,
+        //     TestPlatformOptions options,
+        //     TestSessionInfo testSessionInfo,
+        //     ITestDiscoveryEventsHandler2 discoveryEventsHandler);
 
         /// <summary>
         /// Cancels the last discovery request.
@@ -100,21 +100,21 @@ void RunTests(
             TestPlatformOptions options,
             ITestRunEventsHandler testRunEventsHandler);
 
-        /// <summary>
-        /// Starts a test run.
-        /// </summary>
-        /// 
-        /// <param name="sources">The list of source assemblies for the test run.</param>
-        /// <param name="runSettings">The run settings for the run.</param>
-        /// <param name="options">The test platform options.</param>
-        /// <param name="testSessionInfo">The test session info object.</param>
-        /// <param name="testRunEventsHandler">The run event handler.</param>
-        void RunTests(
-            IEnumerable<string> sources,
-            string runSettings,
-            TestPlatformOptions options,
-            TestSessionInfo testSessionInfo,
-            ITestRunEventsHandler testRunEventsHandler);
+        // <summary>
+        // Starts a test run.
+        // </summary>
+        // 
+        // <param name="sources">The list of source assemblies for the test run.</param>
+        // <param name="runSettings">The run settings for the run.</param>
+        // <param name="options">The test platform options.</param>
+        // <param name="testSessionInfo">The test session info object.</param>
+        // <param name="testRunEventsHandler">The run event handler.</param>
+        // void RunTests(
+        //     IEnumerable<string> sources,
+        //     string runSettings,
+        //     TestPlatformOptions options,
+        //     TestSessionInfo testSessionInfo,
+        //     ITestRunEventsHandler testRunEventsHandler);
 
         /// <summary>
         /// Starts a test run.
@@ -142,21 +142,21 @@ void RunTests(
             TestPlatformOptions options,
             ITestRunEventsHandler testRunEventsHandler);
 
-        /// <summary>
-        /// Starts a test run.
-        /// </summary>
-        /// 
-        /// <param name="testCases">The list of test cases for the test run.</param>
-        /// <param name="runSettings">The run settings for the run.</param>
-        /// <param name="options">The test platform options.</param>
-        /// <param name="testSessionInfo">The test session info object.</param>
-        /// <param name="testRunEventsHandler">The run event handler.</param>
-        void RunTests(
-            IEnumerable<TestCase> testCases,
-            string runSettings,
-            TestPlatformOptions options,
-            TestSessionInfo testSessionInfo,
-            ITestRunEventsHandler testRunEventsHandler);
+        // <summary>
+        // Starts a test run.
+        // </summary>
+        // 
+        // <param name="testCases">The list of test cases for the test run.</param>
+        // <param name="runSettings">The run settings for the run.</param>
+        // <param name="options">The test platform options.</param>
+        // <param name="testSessionInfo">The test session info object.</param>
+        // <param name="testRunEventsHandler">The run event handler.</param>
+        // void RunTests(
+        //     IEnumerable<TestCase> testCases,
+        //     string runSettings,
+        //     TestPlatformOptions options,
+        //     TestSessionInfo testSessionInfo,
+        //     ITestRunEventsHandler testRunEventsHandler);
 
         /// <summary>
         /// Starts a test run.
@@ -188,23 +188,23 @@ void RunTestsWithCustomTestHost(
             ITestRunEventsHandler testRunEventsHandler,
             ITestHostLauncher customTestHostLauncher);
 
-        /// <summary>
-        /// Starts a test run.
-        /// </summary>
-        /// 
-        /// <param name="sources">The list of source assemblies for the test run.</param>
-        /// <param name="runSettings">The run settings for the run.</param>
-        /// <param name="options">The test platform options.</param>
-        /// <param name="testSessionInfo">The test session info object.</param>
-        /// <param name="testRunEventsHandler">The run event handler.</param>
-        /// <param name="customTestHostLauncher">The custom host launcher.</param>
-        void RunTestsWithCustomTestHost(
-            IEnumerable<string> sources,
-            string runSettings,
-            TestPlatformOptions options,
-            TestSessionInfo testSessionInfo,
-            ITestRunEventsHandler testRunEventsHandler,
-            ITestHostLauncher customTestHostLauncher);
+        // <summary>
+        // Starts a test run.
+        // </summary>
+        // 
+        // <param name="sources">The list of source assemblies for the test run.</param>
+        // <param name="runSettings">The run settings for the run.</param>
+        // <param name="options">The test platform options.</param>
+        // <param name="testSessionInfo">The test session info object.</param>
+        // <param name="testRunEventsHandler">The run event handler.</param>
+        // <param name="customTestHostLauncher">The custom host launcher.</param>
+        // void RunTestsWithCustomTestHost(
+        //     IEnumerable<string> sources,
+        //     string runSettings,
+        //     TestPlatformOptions options,
+        //     TestSessionInfo testSessionInfo,
+        //     ITestRunEventsHandler testRunEventsHandler,
+        //     ITestHostLauncher customTestHostLauncher);
 
         /// <summary>
         /// Starts a test run.
@@ -236,83 +236,83 @@ void RunTestsWithCustomTestHost(
             ITestRunEventsHandler testRunEventsHandler,
             ITestHostLauncher customTestHostLauncher);
 
-        /// <summary>
-        /// Starts a test run.
-        /// </summary>
-        /// 
-        /// <param name="testCases">The list of test cases for the test run.</param>
-        /// <param name="runSettings">The run settings for the run.</param>
-        /// <param name="options">The test platform options.</param>
-        /// <param name="testSessionInfo">The test session info object.</param>
-        /// <param name="testRunEventsHandler">The run event handler.</param>
-        /// <param name="customTestHostLauncher">The custom host launcher.</param>
-        void RunTestsWithCustomTestHost(
-            IEnumerable<TestCase> testCases,
-            string runSettings,
-            TestPlatformOptions options,
-            TestSessionInfo testSessionInfo,
-            ITestRunEventsHandler testRunEventsHandler,
-            ITestHostLauncher customTestHostLauncher);
+        // <summary>
+        // Starts a test run.
+        // </summary>
+        // 
+        // <param name="testCases">The list of test cases for the test run.</param>
+        // <param name="runSettings">The run settings for the run.</param>
+        // <param name="options">The test platform options.</param>
+        // <param name="testSessionInfo">The test session info object.</param>
+        // <param name="testRunEventsHandler">The run event handler.</param>
+        // <param name="customTestHostLauncher">The custom host launcher.</param>
+        // void RunTestsWithCustomTestHost(
+        //     IEnumerable<TestCase> testCases,
+        //     string runSettings,
+        //     TestPlatformOptions options,
+        //     TestSessionInfo testSessionInfo,
+        //     ITestRunEventsHandler testRunEventsHandler,
+        //     ITestHostLauncher customTestHostLauncher);
 
-        /// <summary>
-        /// Starts a new test session.
-        /// </summary>
-        /// 
-        /// <param name="sources">The list of source assemblies for the test run.</param>
-        /// <param name="runSettings">The run settings for the run.</param>
-        /// <param name="eventsHandler">The session event handler.</param>
-        /// 
-        /// <returns>A test session info object.</returns>
-        ITestSession StartTestSession(
-            IList<string> sources,
-            string runSettings,
-            ITestSessionEventsHandler eventsHandler);
+        // <summary>
+        // Starts a new test session.
+        // </summary>
+        // 
+        // <param name="sources">The list of source assemblies for the test run.</param>
+        // <param name="runSettings">The run settings for the run.</param>
+        // <param name="eventsHandler">The session event handler.</param>
+        // 
+        // <returns>A test session info object.</returns>
+        // ITestSession StartTestSession(
+        //     IList<string> sources,
+        //     string runSettings,
+        //     ITestSessionEventsHandler eventsHandler);
 
-        /// <summary>
-        /// Starts a new test session.
-        /// </summary>
-        /// 
-        /// <param name="sources">The list of source assemblies for the test run.</param>
-        /// <param name="runSettings">The run settings for the run.</param>
-        /// <param name="options">The test platform options.</param>
-        /// <param name="eventsHandler">The session event handler.</param>
-        /// 
-        /// <returns>A test session info object.</returns>
-        ITestSession StartTestSession(
-            IList<string> sources,
-            string runSettings,
-            TestPlatformOptions options,
-            ITestSessionEventsHandler eventsHandler);
+        // <summary>
+        // Starts a new test session.
+        // </summary>
+        // 
+        // <param name="sources">The list of source assemblies for the test run.</param>
+        // <param name="runSettings">The run settings for the run.</param>
+        // <param name="options">The test platform options.</param>
+        // <param name="eventsHandler">The session event handler.</param>
+        // 
+        // <returns>A test session info object.</returns>
+        // ITestSession StartTestSession(
+        //     IList<string> sources,
+        //     string runSettings,
+        //     TestPlatformOptions options,
+        //     ITestSessionEventsHandler eventsHandler);
 
-        /// <summary>
-        /// Starts a new test session.
-        /// </summary>
-        /// 
-        /// <param name="sources">The list of source assemblies for the test run.</param>
-        /// <param name="runSettings">The run settings for the run.</param>
-        /// <param name="options">The test platform options.</param>
-        /// <param name="eventsHandler">The session event handler.</param>
-        /// <param name="testHostLauncher">The custom host launcher.</param>
-        /// 
-        /// <returns>A test session info object.</returns>
-        ITestSession StartTestSession(
-            IList<string> sources,
-            string runSettings,
-            TestPlatformOptions options,
-            ITestSessionEventsHandler eventsHandler,
-            ITestHostLauncher testHostLauncher);
+        // <summary>
+        // Starts a new test session.
+        // </summary>
+        // 
+        // <param name="sources">The list of source assemblies for the test run.</param>
+        // <param name="runSettings">The run settings for the run.</param>
+        // <param name="options">The test platform options.</param>
+        // <param name="eventsHandler">The session event handler.</param>
+        // <param name="testHostLauncher">The custom host launcher.</param>
+        // 
+        // <returns>A test session info object.</returns>
+        // ITestSession StartTestSession(
+        //     IList<string> sources,
+        //     string runSettings,
+        //     TestPlatformOptions options,
+        //     ITestSessionEventsHandler eventsHandler,
+        //     ITestHostLauncher testHostLauncher);
 
-        /// <summary>
-        /// Stops the test session.
-        /// </summary>
-        /// 
-        /// <param name="testSessionInfo">The test session info object.</param>
-        /// <param name="eventsHandler">The session event handler.</param>
-        /// 
-        /// <returns>True if the session was successfuly stopped, false otherwise.</returns>
-        bool StopTestSession(
-            TestSessionInfo testSessionInfo,
-            ITestSessionEventsHandler eventsHandler);
+        // <summary>
+        // Stops the test session.
+        // </summary>
+        // 
+        // <param name="testSessionInfo">The test session info object.</param>
+        // <param name="eventsHandler">The session event handler.</param>
+        // 
+        // <returns>True if the session was successfuly stopped, false otherwise.</returns>
+        // bool StopTestSession(
+        //     TestSessionInfo testSessionInfo,
+        //     ITestSessionEventsHandler eventsHandler);
 
         /// <summary>
         /// Cancels the last test run.