Simplify implementation signatures for blittable parameters (#1042)

microsoft · Aug 13, 2021 · 1dd9a40 · 1dd9a40
1 parent 700eb26
commit 1dd9a40
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/crates/gen/src/parser/method_signature.rs b/crates/gen/src/parser/method_signature.rs
@@ -480,7 +480,7 @@ impl MethodParam {
         let kind = self.signature.kind.gen_name(gen);
 
         if self.param.is_input() {
-            if self.signature.kind.is_primitive() {
+            if self.signature.kind.is_blittable() {
                 quote! { #name }
             } else {
                 quote! { &*(&#name as *const <#kind as ::windows::Abi>::Abi as *const <#kind as ::windows::Abi>::DefaultType) }

diff --git a/tests/implement/tests/com_chain.rs b/tests/implement/tests/com_chain.rs
@@ -21,8 +21,7 @@ impl Test {
         Ok(())
     }
 
-    // TODO: should be able to declare BOOL without a reference.
-    fn Save(&self, _: &Option<IStream>, _: &BOOL) -> Result<()> {
+    fn Save(&self, _: &Option<IStream>, _: BOOL) -> Result<()> {
         Ok(())
     }
-Original file line number
+Diff line change
@@ Expand Up / @@ -21,8 +21,7 @@ impl Test { @@
             Ok(())
         }
-        // TODO: should be able to declare BOOL without a reference.
-        fn Save(&self, _: &Option<IStream>, _: &BOOL) -> Result<()> {
+        fn Save(&self, _: &Option<IStream>, _: BOOL) -> Result<()> {
             Ok(())
         }
@@ Expand Down @@