Zero hint values in .idata$6 sections for GNU libs #3239
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Alternatively, we could toss this PR and just re-generate new libs using the current bintools and bank on upstream metadata function order not changing. (I think if we move functions between namespaces in metadata, they will get emitted into the metadata tables in a slightly different order.) |
|
Happy to take a one time update to gnu libs to bring them in line and avoid a bunch of code churn. |
|
Sure, let's give that a shot then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #3237
In Binutils 2.43, a long-standing quirk related to the emission of the PE hint/name table (.idata$6) was reverted, causing the hints to now be emitted with numerically increasing values. This change was detected during our library workflow pass. Since the order of functions in the upstream metadata is not guaranteed and the new hints are not valid, we are now zeroing out the hints in a post-processing step to restore consistency.