Fix remaining std references in windows and windows-core crates for no_std builds
#3317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennykerr
changed the title
std references in windows and core crates for no_std buildsstd references in windows and windows-core crates for no_std builds
|
I can confirm this branch works fine and I can create a Direct3D device, create vertex buffers, etc. Thanks for the quick response! |
|
Sweet - thanks for checking! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'll think some more about how to test this, but at least for now this should deal with this issue.
Fixes: #3315
This also changes the Direct3D12 sample to build with
no_stdfor validation and illustration purposes.