Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build error in the example in readme.md #780

Closed
wants to merge 1 commit into from

Conversation

cnwzhjs
Copy link

@cnwzhjs cnwzhjs commented May 8, 2021

The example in the readme.md causes proc error:
error: proc macro panicked
--> build.rs:2:5
|
2 | / windows::build!(
3 | | Windows::Data::Xml::Dom::*,
4 | | Windows::Win32::System::WindowsProgramming::CloseHandle,
5 | | Windows::Win32::UI::WindowsAndMessaging::MessageBoxA,
... |
11 | | },
12 | | );
| |______^
|
= help: message: Could not find namespace Windows.Win32.System.WindowsProgramming

which is introduced by the namespace change.

This PR fixes this compile error

@ghost
Copy link

ghost commented May 8, 2021

CLA assistant check
All CLA requirements met.

@cnwzhjs cnwzhjs marked this pull request as draft May 8, 2021 04:41
@cnwzhjs cnwzhjs marked this pull request as ready for review May 8, 2021 04:42
Copy link
Contributor

@MarijnS95 MarijnS95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is correct, these are the old namespaces. Please see #782, all that needed to change is moving WaitForSingleObject under Threading (and a missing comma between the Threading::{} and SystemServices::{} block, that has been solved by reordering and not having SystemServices imports at all anymore).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants