-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proxy options support #190
Comments
Possible proxy configuration options are:
|
1080端口,老局域网用户了 |
please consider also proxy the download link inside the package , for example ,
please also proxy the download link 'https://mirrors.kodi.tv/releases/windows/win64/kodi-18.7-Leia-x64.exe' which insided the installation package. |
I would recommend standard variables like HTTP_PROXY or HTTPS_PROXY |
When adding proxy support, please do not forget supporting proxies that require NTLM-authentication!!! Thank you! |
Any plan regarding this feature? |
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
1 similar comment
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
Also need for |
This comment was marked as spam.
This comment was marked as spam.
Why not try |
@d0zingcat because its not socks5. |
Maybe you could use Privoxy(windows)/polipo(macOS) to parse socks5 to http? |
This comment was marked as spam.
This comment was marked as spam.
not that its an equivalent but even spotify can run over socks5. it would be nice to run winget through tor like all my other package managers to curb targeted injection attacks. |
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
1 similar comment
This comment was marked as spam.
This comment was marked as spam.
The whole point of asking for a custom proxy support is to make sure one is not using systemwide proxy. The systemwide proxy opens connections to everything else o the system. |
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
As a workaround i use: "bitsadmin /util /setieproxy localsystem MANUAL_PROXY " |
All, Please be respectful of others who are watching this Issue. Every comment is sent out as an e-mail to every user watching this Issue. Adding comments like "Need it" or "+1" is just causing more noise. We track relative priority by the number of 👍 on the original post for the Issue. I've hid the majority of these comments, as they do not add to the scope of the issue or offer support for others who also want this feature and are essentially "subscribed" because they have added their 👍. This issue is now high on the backlog. We have several security concerns we have to address in order to enable this feature. As soon as we have a design that is acceptable for our security requirements, we will look to sequence this work for engineering. You can see how we prioritize work on the Roadmap. |
Is there any plan that can be used ? |
It's been more than three years since this issue was created, and we see that this issue has a linked PR #1776, which solves some problems. After that PR, this issue was added to the milestones: v1.3-Client, v1.4-Client, v1.5-Client and now v.Next-Client. As the differences between commits increase due to the development of master branches, merge PR has become a challenge by now. Moreover, according to RoadMap, this issue is already the issue with the largest number of 👍 among milestone: v.Next-Client. Can we first merge this PR as an experimental feature, and then gradually fix it according to the new problems we encounter? |
We have to adhere to our internal security standards which is why that PR hasn't been merged. We're working on getting the documentation together for our security review, and then we'll be able to either start from that PR or create a new one with the approved method. It will initially start out as an experimental feature in a preview and then it can be made stable feature in the next stable release. I've changed how we're tracking work across milestones to avoid the constant movement. We've had several other high-priority features and bug fixes in progress, but this has made it to the top of the list for asks from the community. |
Hey everyone, I know it's been a long time coming, but we have had our initial security review. We will be submitting a specification document and will work on final review and then we can get into implementation.
I want to thank @eternalphane for the draft PR: |
waiting for the good news |
You mention a GPO. Is there a plan to also include Intune, using a configuration policy, as a means for enterprise control? We have many workstations that are not domain joined, only Entra joined, that have no GPOs and no intention of introducing any. |
For #190 See spec on #4152 See #1776 for a related PR for the feature with the core implementation for proxies in wininet This PR adds basic support for using proxies. Most of the changes are for enabling the configuration and blocking of the feature. This feature will be gated behind an experimental feature setting * Added Group Policy and Admin settings for enabling/disabling the use of proxy CLI arguments and for setting a default proxy. + Pending: Internal review for new Group Policy + Extended `AdminSettings` to support settings with string values, instead of only bool flags. The implementation is mostly a copy of the bool case. In the future we should look back at it to reduce duplication of code. + Added a `set` subcommand to `settings` that can set the admin settings * Added CLI arguments to select a proxy on each different invocation of winget, or to disable the use of a default one. * Updated calls to wininet and cpprestsdk to use the provided proxy, and added plumbing to get the arguments from the command line to the point of use. * Changed the flow around downloads to force winget to use proxies if available. Manually tested on a VM using mitmproxy Pending: Adding automated tests tests. Co-authored-by: yao-msft <50888816+yao-msft@users.noreply.github.com>
the Intune situation should be considered too as a part of supporting proxies. this issue can be closed then. |
Hey everybody, the "Proxy" experimental feature is available in the latest WinGet 1.8 preview release. I'd like to see a few folks test the feature out, but I don't want to add more noise here on the issue that triggers e-mails to everyone subscribed. Please test out the feature and provide your results over at: |
We're getting ready to make the proxy support a stable feature for WinGet 1.8. When that release is created, I'll be closing this issue. If there are any additional requests related to proxy support, please create new issues. |
What about proxy with user/pass authentication ? |
Description of the new feature/enhancement
Something like:
This will make
winget
downloadgit
through the proxy server.The text was updated successfully, but these errors were encountered: