Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicated message about unknown versions #1982

Merged
merged 1 commit into from
Feb 28, 2022

Conversation

felipecrs
Copy link
Contributor

@felipecrs felipecrs commented Feb 28, 2022


It turns out that this message is displayed twice, without a reason. Example:

$ winget upgrade --all
Name  Id             Version Available Source
---------------------------------------------
gsudo gerardog.gsudo 1.0.2.0 1.1.0     winget
1 upgrades available.
10 packages have version numbers that cannot be determined. Use "--include-unknown" to see all results.

(1/1) Found gsudo [gerardog.gsudo] Version 1.1.0
This application is licensed to you by its owner.
Microsoft is not responsible for, nor does it grant any licenses to, third-party packages.
Downloading https://github.com/gerardog/gsudo/releases/download/v1.1.0/gsudoSetup.msi
  ██████████████████████████████   364 KB /  364 KB
Successfully verified installer hash
Starting package install...
Successfully installed

10 packages have version numbers that cannot be determined. Use "--include-unknown" to see all results.

$ winget upgrade --all
No installed package found matching input criteria.
10 packages have version numbers that cannot be determined. Use "--include-unknown" to see all results.
No applicable update found.
10 packages have version numbers that cannot be determined. Use "--include-unknown" to see all results.

This PR removes the latter duplicated message.

Microsoft Reviewers: Open in CodeFlow

@felipecrs felipecrs requested a review from a team as a code owner February 28, 2022 15:08
@yao-msft
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@yao-msft
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@yao-msft yao-msft merged commit 16de635 into microsoft:master Feb 28, 2022
@felipecrs felipecrs deleted the remove-duplicated-message branch March 1, 2022 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants