-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Show package tags #2235
Feat: Show package tags #2235
Conversation
Why not add the tags to the normal output of |
Because iirc the normal show will show information, and --tags will show the tags from all locales. |
But now that you bring up the locale in |
Thats a fair point; I was going based just on the issue, but I can see how just showing the tags would be better |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It may be good to add this to the unit tests for show
.
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
I've tested v1.4.2161-preview and |
Tags are per version and per locale. To implement it as described in the original request would require either selection of a version and locale, or to aggregate all the tags from all locales and versions which would produce unwieldly data.
The default behavior then would have to be to show the latest version and applicable locale (or defaultLocale if none were applicable), which is the same behavior as integrating it directly into the show command. If you read through the history above, I actually had implemented it as a separate argument initially, but then upon feedback it was changed since it would essentially be showing just the tags portion of the output and it doesn't make sense to require a separate argument for that. |
Microsoft Reviewers: Open in CodeFlow