Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply latest localization patch #2264

Merged
merged 1 commit into from
Jun 21, 2022
Merged

Conversation

ryfu-msft
Copy link
Contributor

@ryfu-msft ryfu-msft commented Jun 20, 2022

This PR updates the localizations for strings up to commit 7d86fc0

Microsoft Reviewers: Open in CodeFlow

@ryfu-msft ryfu-msft requested a review from a team as a code owner June 20, 2022 21:56
Copy link
Member

@florelis florelis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll see about submitting these comments to the localization team.

<value>Pide al usuario que presione cualquier tecla antes de salir</value>
</data>
<data name="InstallerElevationExpected" xml:space="preserve">
<value>El instalador solicitará que se ejecute como administrador; se espera un mensaje.</value>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of "se espera un mensaje", I think it should be "espere un mensaje". I.e., instead of "a prompt is expected", something more along the lines of "you should expect a prompt". I'm also not sure if "prompt" should be "mensaje" in this case? Maybe "cuadro de diálogo"?

<value>Variable de entorno PATH modificada; reinicie el shell para usar el nuevo valor.</value>
</data>
<data name="ProductCodeArgumentDescription" xml:space="preserve">
<value>Filtros con el código de producto</value>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original message was "filters using the product code". I think "filters" here is a verb and not a noun, right? As in "it filters" and not "these are filters". If so, this should be "Filtra".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you are correct, filters in this scenario is used as a verb.

<value>Filtros con el código de producto</value>
</data>
<data name="PortableRegistryCollisionOverridden" xml:space="preserve">
<value>Ya existe un paquete portátil con el mismo nombre pero de otro origen; continuar debido a --force</value>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"continuar" should be "continuando"

<value>Filtros con el código de producto</value>
</data>
<data name="PortableRegistryCollisionOverridden" xml:space="preserve">
<value>Ya existe un paquete portátil con el mismo nombre pero de otro origen; continuar debido a --force</value>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a Lock message on force?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lock message for --force is missing for this string. Needs to be added

@@ -1268,4 +1275,78 @@ Especifique uno de ellos con la opción '--source' para continuar.</value>
<data name="SystemArchitecture" xml:space="preserve">
<value>Arquitectura del sistema</value>
</data>
<data name="PreserveArgumentDescription" xml:space="preserve">
<value>Conserva todos los archivos y directorios creados por el paquete (archivo portátil)</value>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"archivo portátil" means "portable file". Should it not be app or package instead of file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be "portable package"

<value>Se proporcionan los argumentos "purge" y "preserve"</value>
</data>
<data name="PortableHashMismatchOverridden" xml:space="preserve">
<value>Se ha modificado el archivo EXE portátil; continuar debido a --force</value>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

continuar -> continuando

Comment on lines +1343 to +1350
<data name="ShowLabelDocumentation" xml:space="preserve">
<value>Documentación:</value>
</data>
<data name="Notes" xml:space="preserve">
<value>Notas:</value>
</data>
<data name="ShowLabelInstallationNotes" xml:space="preserve">
<value>InstallationNotes:</value>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation is localized but not InstallationNotes. We should be consistent, maybe by adding a comment on all of these. I caused this back when I added all the labels to the localization and we talked a little about going back to using the exact manifest field names instead of localizing them, but we never did. #1503

<comment>{Locked="--force"}</comment>
</data>
<data name="FilesRemainInInstallDirectory" xml:space="preserve">
<value>Los archivos permanecen en el directorio de instalación:</value>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't sound right to me how I imagine it being used. It says "The files remain [...]:". I'd think it should be something like "Estos archivos permanecen [...]:" ("these files remain [...]") or "Los siguientes archivos permanecen [...]:" ("the following files remain [...]:")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants