Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Schema additions for Zip support #2288

Merged
merged 6 commits into from
Jul 5, 2022
Merged

Schema additions for Zip support #2288

merged 6 commits into from
Jul 5, 2022

Conversation

ryfu-msft
Copy link
Contributor

@ryfu-msft ryfu-msft commented Jun 29, 2022 •
edited
Loading

This PR make additions to the 1.3 schema to support ZIP installers.

Changes:
Addition of:

  • NestedInstallerType
  • NestedInstallerFiles
    -- RelativeFilePath
    -- PortableCommandAlias

Existing test manifests that used zip installerType have now been replaced with msi in order to avoid schema validation errors that are specific to zip.

Tests:

  • Manifest with zip installer with multiple nested installers
  • Manifest with zip installer with no nested installer file
  • Manifest with zip installer with no nested installer type
  • Manifest with zip installer with no RelativeFilePath defined
  • v1.3 manifest with zip installers

Related to:
#2270
#140

Microsoft Reviewers: Open in CodeFlow

@ryfu-msft ryfu-msft requested a review from a team as a code owner June 29, 2022 19:48
JohnMcPMS
JohnMcPMS requested changes Jul 5, 2022
View reviewed changes
Copy link
Member

@JohnMcPMS JohnMcPMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using the semantic function will help future maintainers understand what was actually being looked for.

src/AppInstallerCommonCore/Manifest/ManifestValidation.cpp Outdated Show resolved Hide resolved
src/AppInstallerCommonCore/Manifest/ManifestYamlPopulator.cpp Outdated Show resolved Hide resolved
@ghost ghost added the Needs-Author-Feedback Issue needs attention from issue or PR author label Jul 5, 2022
@ghost ghost removed the Needs-Author-Feedback Issue needs attention from issue or PR author label Jul 5, 2022
@ryfu-msft ryfu-msft requested a review from JohnMcPMS July 5, 2022 22:05
@ryfu-msft ryfu-msft merged commit dea9a20 into microsoft:master Jul 5, 2022
@denelon
Copy link
Contributor

denelon commented Jul 12, 2022

Related to:

@ryfu-msft ryfu-msft deleted the zipSchema branch July 29, 2022 20:08
@denelon denelon mentioned this pull request Aug 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yao-msft yao-msft yao-msft approved these changes

@JohnMcPMS JohnMcPMS JohnMcPMS approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ryfu-msft @denelon @JohnMcPMS @yao-msft