Add in-process and out-of-process E2E tests #2315

AmelBawa-msft · 2022-07-07T21:33:14Z

Created "Microsoft.Management.Deployment.Projection" project for calling the COM API.
Copied and adapted existing Install, Uninstall and Upgrade E2E tests to utilize the COM API.
Added pipeline steps to execute the COM API E2E tests

Microsoft Reviewers: Open in CodeFlow

…into E2E-COM-Test

github-actions · 2022-07-07T21:34:35Z

@check-spelling-bot Report

Unrecognized words, please review:

cls
clsctx
coresponding
FIXME
ICreate
IFind
IInstall
IInstance
intance
IUninstall
nameof
typeof
typeparam

Previously acknowledged words that are now absent

activatable amd Archs dsc efgh enr FWW Globals hackathon IID lww mytool OSVERSION Packagedx parametermap pathpaths symlink Uninitialize WDAG whatif wsb

To accept these unrecognized words as correct (and remove the previously acknowledged and now absent words), run the following commands

... in a clone of the git@github.com:AmelBawa-msft/winget-cli.git repository
on the E2E-COM-Test branch:

update_files() {
perl -e '
my @expect_files=qw('".github/actions/spelling/expect.txt"');
@ARGV=@expect_files;
my @stale=qw('"$patch_remove"');
my $re=join "|", @stale;
my $suffix=".".time();
my $previous="";
sub maybe_unlink { unlink($_[0]) if $_[0]; }
while (<>) {
if ($ARGV ne $old_argv) { maybe_unlink($previous); $previous="$ARGV$suffix"; rename($ARGV, $previous); open(ARGV_OUT, ">$ARGV"); select(ARGV_OUT); $old_argv = $ARGV; }
next if /^(?:$re)(?:(?:\r|\n)*$| .*)/; print;
}; maybe_unlink($previous);'
perl -e '
my $new_expect_file=".github/actions/spelling/expect.txt";
use File::Path qw(make_path);
use File::Basename qw(dirname);
make_path (dirname($new_expect_file));
open FILE, q{<}, $new_expect_file; chomp(my @words = <FILE>); close FILE;
my @add=qw('"$patch_add"');
my %items; @items{@words} = @words x (1); @items{@add} = @add x (1);
@words = sort {lc($a)."-".$a cmp lc($b)."-".$b} keys %items;
open FILE, q{>}, $new_expect_file; for my $word (@words) { print FILE "$word\n" if $word =~ /\w/; };
close FILE;
system("git", "add", $new_expect_file);
'
}

comment_json=$(mktemp)
curl -L -s -S \
  --header "Content-Type: application/json" \
  "https://api.github.com/repos/microsoft/winget-cli/issues/comments/1178253557" > "$comment_json"
comment_body=$(mktemp)
jq -r .body < "$comment_json" > $comment_body
rm $comment_json

patch_remove=$(perl -ne 'next unless s{^</summary>(.*)</details>$}{$1}; print' < "$comment_body")
  

patch_add=$(perl -e '$/=undef;
$_=<>;
s{<details>.*}{}s;
s{^#.*}{};
s{\n##.*}{};
s{(?:^|\n)\s*\*}{}g;
s{\s+}{ }g;
print' < "$comment_body")
  
update_files
rm $comment_body
git add -u

src/AppInstallerCLIE2ETests/Interop/InitializersSource.cs

src/Microsoft.Management.Deployment.Projection/ClassModel.cs

src/AppInstallerCLIE2ETests/Interop/UpgradeInterop.cs

AmelBawa-msft · 2022-07-14T22:38:50Z

/azp run

github-actions · 2022-07-18T15:32:24Z

@check-spelling-bot Report

Unrecognized words, please review:

cls
clsctx
Filtercriteria
Finalizers
ICreate
IFind
IInstall
IInstance
intance
IUninstall
nameof
typeof
typeparam

Previously acknowledged words that are now absent

activatable amd Archs dsc efgh enr FWW Globals hackathon IID LPITEMIDLIST lww mytool OSVERSION Packagedx parametermap pathpaths PIDLIST symlink Uninitialize WDAG whatif wsb

To accept these unrecognized words as correct (and remove the previously acknowledged and now absent words), run the following commands

... in a clone of the git@github.com:AmelBawa-msft/winget-cli.git repository
on the E2E-COM-Test branch:

update_files() {
perl -e '
my @expect_files=qw('".github/actions/spelling/expect.txt"');
@ARGV=@expect_files;
my @stale=qw('"$patch_remove"');
my $re=join "|", @stale;
my $suffix=".".time();
my $previous="";
sub maybe_unlink { unlink($_[0]) if $_[0]; }
while (<>) {
if ($ARGV ne $old_argv) { maybe_unlink($previous); $previous="$ARGV$suffix"; rename($ARGV, $previous); open(ARGV_OUT, ">$ARGV"); select(ARGV_OUT); $old_argv = $ARGV; }
next if /^(?:$re)(?:(?:\r|\n)*$| .*)/; print;
}; maybe_unlink($previous);'
perl -e '
my $new_expect_file=".github/actions/spelling/expect.txt";
use File::Path qw(make_path);
use File::Basename qw(dirname);
make_path (dirname($new_expect_file));
open FILE, q{<}, $new_expect_file; chomp(my @words = <FILE>); close FILE;
my @add=qw('"$patch_add"');
my %items; @items{@words} = @words x (1); @items{@add} = @add x (1);
@words = sort {lc($a)."-".$a cmp lc($b)."-".$b} keys %items;
open FILE, q{>}, $new_expect_file; for my $word (@words) { print FILE "$word\n" if $word =~ /\w/; };
close FILE;
system("git", "add", $new_expect_file);
'
}

comment_json=$(mktemp)
curl -L -s -S \
  --header "Content-Type: application/json" \
  "https://api.github.com/repos/microsoft/winget-cli/issues/comments/1187648122" > "$comment_json"
comment_body=$(mktemp)
jq -r .body < "$comment_json" > $comment_body
rm $comment_json

patch_remove=$(perl -ne 'next unless s{^</summary>(.*)</details>$}{$1}; print' < "$comment_body")
  

patch_add=$(perl -e '$/=undef;
$_=<>;
s{<details>.*}{}s;
s{^#.*}{};
s{\n##.*}{};
s{(?:^|\n)\s*\*}{}g;
s{\s+}{ }g;
print' < "$comment_body")
  
update_files
rm $comment_body
git add -u

github-actions · 2022-07-18T17:08:22Z

@check-spelling-bot Report

Unrecognized words, please review:

cls
clsctx
Filtercriteria
Finalizers
ICreate
IFind
IInstall
IInstance
intance
IUninstall
nameof
typeof
typeparam

Previously acknowledged words that are now absent

activatable amd Archs dsc efgh enr FWW Globals hackathon IID LPITEMIDLIST lww mytool OSVERSION Packagedx parametermap pathpaths PIDLIST symlink Uninitialize WDAG whatif wsb

To accept these unrecognized words as correct (and remove the previously acknowledged and now absent words), run the following commands

... in a clone of the git@github.com:AmelBawa-msft/winget-cli.git repository
on the E2E-COM-Test branch:

update_files() {
perl -e '
my @expect_files=qw('".github/actions/spelling/expect.txt"');
@ARGV=@expect_files;
my @stale=qw('"$patch_remove"');
my $re=join "|", @stale;
my $suffix=".".time();
my $previous="";
sub maybe_unlink { unlink($_[0]) if $_[0]; }
while (<>) {
if ($ARGV ne $old_argv) { maybe_unlink($previous); $previous="$ARGV$suffix"; rename($ARGV, $previous); open(ARGV_OUT, ">$ARGV"); select(ARGV_OUT); $old_argv = $ARGV; }
next if /^(?:$re)(?:(?:\r|\n)*$| .*)/; print;
}; maybe_unlink($previous);'
perl -e '
my $new_expect_file=".github/actions/spelling/expect.txt";
use File::Path qw(make_path);
use File::Basename qw(dirname);
make_path (dirname($new_expect_file));
open FILE, q{<}, $new_expect_file; chomp(my @words = <FILE>); close FILE;
my @add=qw('"$patch_add"');
my %items; @items{@words} = @words x (1); @items{@add} = @add x (1);
@words = sort {lc($a)."-".$a cmp lc($b)."-".$b} keys %items;
open FILE, q{>}, $new_expect_file; for my $word (@words) { print FILE "$word\n" if $word =~ /\w/; };
close FILE;
system("git", "add", $new_expect_file);
'
}

comment_json=$(mktemp)
curl -L -s -S \
  --header "Content-Type: application/json" \
  "https://api.github.com/repos/microsoft/winget-cli/issues/comments/1187784592" > "$comment_json"
comment_body=$(mktemp)
jq -r .body < "$comment_json" > $comment_body
rm $comment_json

patch_remove=$(perl -ne 'next unless s{^</summary>(.*)</details>$}{$1}; print' < "$comment_body")
  

patch_add=$(perl -e '$/=undef;
$_=<>;
s{<details>.*}{}s;
s{^#.*}{};
s{\n##.*}{};
s{(?:^|\n)\s*\*}{}g;
s{\s+}{ }g;
print' < "$comment_body")
  
update_files
rm $comment_body
git add -u

github-actions · 2022-07-18T17:11:45Z

@check-spelling-bot Report

Unrecognized words, please review:

Amd
Dsc
EFGH
Hackathon
iid
PARAMETERMAP
pidlist
uninitialize
Whatif

Previously acknowledged words that are now absent

activatable LPITEMIDLIST OSVERSION Packagedx

To accept these unrecognized words as correct (and remove the previously acknowledged and now absent words), run the following commands

... in a clone of the git@github.com:AmelBawa-msft/winget-cli.git repository
on the E2E-COM-Test branch:

update_files() {
perl -e '
my @expect_files=qw('".github/actions/spelling/expect.txt"');
@ARGV=@expect_files;
my @stale=qw('"$patch_remove"');
my $re=join "|", @stale;
my $suffix=".".time();
my $previous="";
sub maybe_unlink { unlink($_[0]) if $_[0]; }
while (<>) {
if ($ARGV ne $old_argv) { maybe_unlink($previous); $previous="$ARGV$suffix"; rename($ARGV, $previous); open(ARGV_OUT, ">$ARGV"); select(ARGV_OUT); $old_argv = $ARGV; }
next if /^(?:$re)(?:(?:\r|\n)*$| .*)/; print;
}; maybe_unlink($previous);'
perl -e '
my $new_expect_file=".github/actions/spelling/expect.txt";
use File::Path qw(make_path);
use File::Basename qw(dirname);
make_path (dirname($new_expect_file));
open FILE, q{<}, $new_expect_file; chomp(my @words = <FILE>); close FILE;
my @add=qw('"$patch_add"');
my %items; @items{@words} = @words x (1); @items{@add} = @add x (1);
@words = sort {lc($a)."-".$a cmp lc($b)."-".$b} keys %items;
open FILE, q{>}, $new_expect_file; for my $word (@words) { print FILE "$word\n" if $word =~ /\w/; };
close FILE;
system("git", "add", $new_expect_file);
'
}

comment_json=$(mktemp)
curl -L -s -S \
  --header "Content-Type: application/json" \
  "https://api.github.com/repos/microsoft/winget-cli/issues/comments/1187793609" > "$comment_json"
comment_body=$(mktemp)
jq -r .body < "$comment_json" > $comment_body
rm $comment_json

patch_remove=$(perl -ne 'next unless s{^</summary>(.*)</details>$}{$1}; print' < "$comment_body")
  

patch_add=$(perl -e '$/=undef;
$_=<>;
s{<details>.*}{}s;
s{^#.*}{};
s{\n##.*}{};
s{(?:^|\n)\s*\*}{}g;
s{\s+}{ }g;
print' < "$comment_body")
  
update_files
rm $comment_body
git add -u

github-actions · 2022-07-18T17:20:39Z

@check-spelling-bot Report

Unrecognized words, please review:

lpitemidlist

To accept these unrecognized words as correct, run the following commands

... in a clone of the git@github.com:AmelBawa-msft/winget-cli.git repository
on the E2E-COM-Test branch:

update_files() {
perl -e '
my $new_expect_file=".github/actions/spelling/expect.txt";
use File::Path qw(make_path);
use File::Basename qw(dirname);
make_path (dirname($new_expect_file));
open FILE, q{<}, $new_expect_file; chomp(my @words = <FILE>); close FILE;
my @add=qw('"$patch_add"');
my %items; @items{@words} = @words x (1); @items{@add} = @add x (1);
@words = sort {lc($a)."-".$a cmp lc($b)."-".$b} keys %items;
open FILE, q{>}, $new_expect_file; for my $word (@words) { print FILE "$word\n" if $word =~ /\w/; };
close FILE;
system("git", "add", $new_expect_file);
'
}

comment_json=$(mktemp)
curl -L -s -S \
  --header "Content-Type: application/json" \
  "https://api.github.com/repos/microsoft/winget-cli/issues/comments/1187830880" > "$comment_json"
comment_body=$(mktemp)
jq -r .body < "$comment_json" > $comment_body
rm $comment_json

patch_add=$(perl -e '$/=undef;
$_=<>;
s{<details>.*}{}s;
s{^#.*}{};
s{\n##.*}{};
s{(?:^|\n)\s*\*}{}g;
s{\s+}{ }g;
print' < "$comment_body")
  
update_files
rm $comment_body
git add -u

src/Microsoft.Management.Deployment.Projection/ClassesDefinition.cs

src/AppInstallerCLIE2ETests/TestCommon.cs

src/AppInstallerCLIE2ETests/AppInstallerCLIE2ETests.csproj

...Microsoft.Management.Deployment.Projection/Microsoft.Management.Deployment.Projection.csproj

yao-msft

commit d8e4fe4 Merge: 8aa5a4e 156282c Author: Jonathan Abbott <jtabbott2001@gmail.com> Date: Thu Jul 21 15:22:30 2022 -0700 Merge branch 'master' of https://github.com/microsoft/winget-cli into user/t-jabbott/powershell commit 156282c Author: AmirMS <104940545+AmelBawa-msft@users.noreply.github.com> Date: Thu Jul 21 14:31:32 2022 -0700 Add in-process and out-of-process E2E tests (microsoft#2315) commit 90f1393 Author: JohnMcPMS <johnmcp@microsoft.com> Date: Thu Jul 21 14:16:47 2022 -0700 Move to using sqlite3_errmsg to extract a contextual error for SQLite failures (microsoft#2352)

AmelBawa-msft added 19 commits June 22, 2022 09:28

Init WPM calls from Nunit

f9489f1

Init test file

6a9ba37

Init COM install command tests cases

ad915b9

Installer tests

a017115

Init COM upgrade command test

d72063a

Init COM uninstall command test

af5d576

Added projection

0973699

Updated initializer and added factory methods

0fab6c4

Update Install tests

dded477

Update Uninstall tests

f96a2c9

Update Upgrade tests

77624f0

removed try/catch

c0b42f4

Renamed csproj

0792869

Removed ClassObjectinitializer

ac16a67

Code refactoring

d299249

Merge branch 'master' of https://github.com/AmelBawa-msft/winget-cli …

902d099

…into E2E-COM-Test

Added more comments

f3fb79b

Omit precompiled header

76b0c8c

Renamed classes

b9fc7e1

Updated E2Ecsproj

93aa1bb

florelis reviewed Jul 8, 2022

View reviewed changes

src/AppInstallerCLIE2ETests/Interop/InitializersSource.cs Outdated Show resolved Hide resolved

florelis reviewed Jul 8, 2022

View reviewed changes

src/Microsoft.Management.Deployment.Projection/ClassModel.cs Outdated Show resolved Hide resolved

Trenly reviewed Jul 8, 2022

View reviewed changes

src/AppInstallerCLIE2ETests/Interop/UpgradeInterop.cs Show resolved Hide resolved

AmelBawa-msft added 6 commits July 8, 2022 09:19

Testing testFiltercriteria in vstest

731f5a9

Fixed typo and testing pipeline

b2095a4

Testing pipeline

85d949a

Testing pipeline

f1a96dd

Call GC

670c48a

Testing pipeline

f29230c

AmelBawa-msft added 2 commits July 13, 2022 19:17

Merge branch 'master' into E2E-COM-Test

e987f6b

Fix build post merge

fb411ed

AmelBawa-msft added 6 commits July 15, 2022 10:32

Updated classe name and addressed comments

2dd80f0

Skip one test for in-proc

6d3a84c

Use interop setup fixture

8a39b87

Skip failing test and created task to investgiate

c8da912

Promote vstest to a yml template

cc5815c

Fixed indentation

a0ba846

Updated spelling file and other minor changes

3ac6466

Merge branch 'master' into E2E-COM-Test

0a0e428

Addressed spelling bot comment

af79723

Addressed spelling bot comment

1b6cb60

AmelBawa-msft marked this pull request as ready for review July 18, 2022 17:40

AmelBawa-msft requested a review from a team as a code owner July 18, 2022 17:40

JohnMcPMS approved these changes Jul 20, 2022

View reviewed changes

src/Microsoft.Management.Deployment.Projection/ClassesDefinition.cs Show resolved Hide resolved

yao-msft reviewed Jul 20, 2022

View reviewed changes

src/AppInstallerCLIE2ETests/TestCommon.cs Outdated Show resolved Hide resolved

yao-msft reviewed Jul 20, 2022

View reviewed changes

src/AppInstallerCLIE2ETests/TestCommon.cs Outdated Show resolved Hide resolved

yao-msft reviewed Jul 20, 2022

View reviewed changes

src/AppInstallerCLIE2ETests/AppInstallerCLIE2ETests.csproj Outdated Show resolved Hide resolved

yao-msft reviewed Jul 20, 2022

View reviewed changes

...Microsoft.Management.Deployment.Projection/Microsoft.Management.Deployment.Projection.csproj Outdated Show resolved Hide resolved

yao-msft approved these changes Jul 20, 2022

View reviewed changes

AmelBawa-msft added 2 commits July 21, 2022 13:12

Addressed comments

cf1948d

Merge branch 'master' into E2E-COM-Test

5348b1e

AmelBawa-msft merged commit 156282c into microsoft:master Jul 21, 2022

AmelBawa-msft deleted the E2E-COM-Test branch July 21, 2022 21:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add in-process and out-of-process E2E tests #2315

Add in-process and out-of-process E2E tests #2315

AmelBawa-msft commented Jul 7, 2022 •

edited

Loading

github-actions bot commented Jul 7, 2022 •

edited

Loading

AmelBawa-msft commented Jul 14, 2022

github-actions bot commented Jul 18, 2022 •

edited

Loading

github-actions bot commented Jul 18, 2022 •

edited

Loading

github-actions bot commented Jul 18, 2022 •

edited

Loading

github-actions bot commented Jul 18, 2022 •

edited

Loading

yao-msft left a comment

Add in-process and out-of-process E2E tests #2315

Add in-process and out-of-process E2E tests #2315

Conversation

AmelBawa-msft commented Jul 7, 2022 • edited Loading

Microsoft Reviewers: Open in CodeFlow

github-actions bot commented Jul 7, 2022 • edited Loading

@check-spelling-bot Report

Unrecognized words, please review:

AmelBawa-msft commented Jul 14, 2022

github-actions bot commented Jul 18, 2022 • edited Loading

@check-spelling-bot Report

Unrecognized words, please review:

github-actions bot commented Jul 18, 2022 • edited Loading

@check-spelling-bot Report

Unrecognized words, please review:

github-actions bot commented Jul 18, 2022 • edited Loading

@check-spelling-bot Report

Unrecognized words, please review:

github-actions bot commented Jul 18, 2022 • edited Loading

@check-spelling-bot Report

Unrecognized words, please review:

yao-msft left a comment

Choose a reason for hiding this comment

AmelBawa-msft commented Jul 7, 2022 •

edited

Loading

github-actions bot commented Jul 7, 2022 •

edited

Loading

github-actions bot commented Jul 18, 2022 •

edited

Loading

github-actions bot commented Jul 18, 2022 •

edited

Loading

github-actions bot commented Jul 18, 2022 •

edited

Loading

github-actions bot commented Jul 18, 2022 •

edited

Loading