Remove /Zi compilation flag #2325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added some extra compilation flags on #2281 for debug information. One of them was
/Ziglobally./ZI(add debug symbols compatible with VS's Edit and Continue) is already added by default for Debug builds (on x86 and x64), and/Zi(add debug symbols) is added by default for Release or ARM builds, so this flag wasn't needed on Release (what we needed) and on Debug it would cause a warning due to using both/Ziand/ZI.This flag can be set in VS with the property "Configuration Properties > C/C++ > General > Debug Information Format", which has the default value.
Microsoft Reviewers: Open in CodeFlow