Expose deeper installation detection through Com

[yao-msft]

null

Microsoft Reviewers: Open in CodeFlow

[JohnMcPMS]

Should these actually be success codes when it is a case of not full success? (not have the error bit set) #Resolved

[JohnMcPMS]

You cannot pull this out of portable; we do not know the actual architecture of the installed package based on the ARP registry location. Even for portable it is dubious, and we should record it into an ARP value (due to ARM64). #Resolved

[JohnMcPMS]

I'm not sure that this needs to be implemented as a member of IPackage versus a standalone function that takes in an IPackage and the other parameters. What is gained from enabling different IPackage implementations to have different implementations of this function? #Resolved

[JohnMcPMS]

There is already a scope enum. #ByDesign

[JohnMcPMS]

This part seems unnecessary if the goal is producing a < b. #ByDesign

[JohnMcPMS]

If we are going to have a map for performance, then you should:

auto itr = find();
if (itr != end)
{
itr = emplace().first;
}

AreEqual(expected, itr->second);

To prevent any more map lookups than necessary. #Resolved

[github-actions]

@check-spelling-bot Report

Unrecognized words, please review:

• IObject
• IWin

To accept these unrecognized words as correct, run the following commands

... in a clone of the git@github.com:yao-msft/winget-cli.git repository
on the detectionimpl branch:

update_files() {
perl -e '
my $new_expect_file=".github/actions/spelling/expect.txt";
use File::Path qw(make_path);
use File::Basename qw(dirname);
make_path (dirname($new_expect_file));
open FILE, q{<}, $new_expect_file; chomp(my @words = <FILE>); close FILE;
my @add=qw('"$patch_add"');
my %items; @items{@words} = @words x (1); @items{@add} = @add x (1);
@words = sort {lc($a)."-".$a cmp lc($b)."-".$b} keys %items;
open FILE, q{>}, $new_expect_file; for my $word (@words) { print FILE "$word\n" if $word =~ /\w/; };
close FILE;
system("git", "add", $new_expect_file);
'
}

comment_json=$(mktemp)
curl -L -s -S \
  --header "Content-Type: application/json" \
  "https://api.github.com/repos/microsoft/winget-cli/issues/comments/1218494533" > "$comment_json"
comment_body=$(mktemp)
jq -r .body < "$comment_json" > $comment_body
rm $comment_json

patch_add=$(perl -e '$/=undef;
$_=<>;
s{<details>.*}{}s;
s{^#.*}{};
s{\n##.*}{};
s{(?:^|\n)\s*\*}{}g;
s{\s+}{ }g;
print' < "$comment_body")
  
update_files
rm $comment_body
git add -u

[JohnMcPMS]

Ensure that consumers are going to be happy with the API design before merging.