-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More localization friendly source strings and context commenting #2454
More localization friendly source strings and context commenting #2454
Conversation
…into localization-format
template<typename ...T> | ||
Utility::LocIndString operator()(T ... args) const; | ||
private: | ||
std::string Resolve() const; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: I don't think the comment "Resolve the string id" is saying much for the Resolve()
function... I'd prefer the comment to explain what "resolve" means or what it resolves to. Something like "resolves the string ID to the localized string it represents, keeping replacement tokens"
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What was done?
winget.resw
file.Test
Microsoft Reviewers: Open in CodeFlow