Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Expected Return Code for InvalidParameter #2635

Merged
merged 5 commits into from
Oct 26, 2022

Conversation

Trenly
Copy link
Contributor

@Trenly Trenly commented Oct 24, 2022


This PR adds two additional expected return codes:

  1. InvalidParameter
  2. SystemNotSupported

It also incorporates these into the default expected return codes where applicable.
This will likely cause a merge conflict with #2617, but I would prefer this PR to be merged first, if accepted.

Other issues fixed:

  • Fixes 'packageInUseByApplication' to use else if instead of if
  • Fixes the expected response of 'ERROR_INSTALL_REJECTED', as that error 1654 is not BlockedByPolicy
Microsoft Reviewers: Open in CodeFlow

@Trenly Trenly marked this pull request as ready for review October 24, 2022 16:44
@Trenly Trenly requested a review from a team as a code owner October 24, 2022 16:44
@yao-msft
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@yao-msft yao-msft merged commit 91a1729 into microsoft:master Oct 26, 2022
@Trenly Trenly deleted the InvalidParameter branch October 26, 2022 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants