Support --no-upgrade option for install flow #2655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trenly
reviewed
Nov 1, 2022
| case APPINSTALLER_CLI_ERROR_INSTALL_PACKAGE_IN_USE: | ||
| return "Application is currently running.Exit the application then try again."; | ||
| return "Application is currently running. Exit the application then try again."; | ||
| case APPINSTALLER_CLI_ERROR_INSTALL_INSTALL_IN_PROGRESS: | ||
| return "Another installation is already in progress.Try again later."; |
There was a problem hiding this comment.
Nit: Since you fixed the space above, might want to fix this one too
ryfu-msft
reviewed
Nov 2, 2022
| @@ -309,7 +309,8 @@ namespace AppInstaller::CLI::Workflow | |||
| context.Reporter.Info() << Resource::String::Cancelled << std::endl; | |||
| return; | |||
| } | |||
| else if (searchContext.GetTerminationHR() == APPINSTALLER_CLI_ERROR_UPDATE_NOT_APPLICABLE) | |||
ryfu-msft
reviewed
Nov 2, 2022
| @@ -1467,4 +1466,10 @@ Please specify one of them using the `--source` option to proceed.</value> | |||
| <value>Archive scan detected malware; proceeding due to --force</value> | |||
| <comment>{Locked="--force"}</comment> | |||
| </data> | |||
| <data name="NoUpgradeArgumentDescription" xml:space="preserve"> | |||
| <value>Do not try to upgrade any installed version during install operation</value> | |||
ryfu-msft
approved these changes
Nov 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #929
There are community asks to allow skipping package upgrade if any version is already installed.
Unit tests added.
Microsoft Reviewers: Open in CodeFlow