Fix issue that only 1 dependency package is installed #2761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florelis
reviewed
Dec 8, 2022
| @@ -223,7 +224,15 @@ namespace AppInstaller::Manifest | |||
| return MinVersion <= Utility::Version(version); | |||
| } | |||
|
|
|||
| // m_foldedId should be set whenever Id is set | |||
There was a problem hiding this comment.
So, the issue was that in some cases it wasn't set?
There was a problem hiding this comment.
Correct. Before the fix, manifest parsing directly sets Id without any way to set m_foldedId resulting in all dependency packages having same folded id and get treated as same package.
florelis
approved these changes
Dec 8, 2022
Comment on lines
205
to
207
| string_t Id() const { return m_id; }; | ||
| std::optional<Utility::Version> MinVersion; | ||
|
|
ryfu-msft
approved these changes
Dec 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added tests. Also verified locally.
Microsoft Reviewers: Open in CodeFlow