Update Repair-WinGetPackageManager with UiXaml 2.8 #4218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnMcPMS
reviewed
Feb 29, 2024
| @@ -73,12 +73,12 @@ internal class AppxModuleHelper | |||
| private const string VCLibsUWPDesktopArm64 = "https://aka.ms/Microsoft.VCLibs.arm64.14.00.Desktop.appx"; | |||
|
|
|||
| // Xaml | |||
| private const string XamlPackage27 = "Microsoft.UI.Xaml.2.7"; | |||
There was a problem hiding this comment.
Just swapping to 2.8 will mean that older versions won't install. I would rather have a fix that handles both situations.
This was referenced Feb 29, 2024
JohnMcPMS
reviewed
Mar 1, 2024
JohnMcPMS
approved these changes
Mar 1, 2024
ryfu-msft
added a commit
to ryfu-msft/winget-cli
that referenced
this pull request
Mar 1, 2024
ryfu-msft
added a commit
that referenced
this pull request
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue with Repair-WinGetPackageManager not installing the correct version of Ui.Xaml (2.8.6) which is required by the latest release (1.7.10582)
Also I checked the commit history and the minimum version that has the update to v2.8.6 for UI.Xaml is our RC candidate 1.7.10514
Microsoft Reviewers: Open in CodeFlow