Make Ignore Warnings suppress the output level entirely #4221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yao-msft
reviewed
Mar 1, 2024
|
Thanks @kaleb with a FANTASIC improvement for users! ❤️ |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
JohnMcPMS
reviewed
Mar 1, 2024
|
Sorry for adding noise - I just wanted to say I'm really impressed with and appreciate the insane response time to #4213 |
Trenly
force-pushed
the
SuppressOutputLevels
branch
from
74deb87 to
ef1589f
Compare
yao-msft
reviewed
Mar 8, 2024
yao-msft
reviewed
Mar 14, 2024
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
yao-msft
approved these changes
Mar 14, 2024
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
yao-msft
previously approved these changes
Mar 14, 2024
|
Thanks for all your patience and guidance @yao-msft, It really helps me understand a lot more about why certain things have been done the way they are |
|
@Trenly I cannot merge due to merge conflicts. Can you merge to latest when you have time? Thanks. |
Should be good now |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
yao-msft
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of handling each case individually, this PR makes the
--ignore-warningsa common argument and suppresses all output fromcontext.Reporter.Warn(). Support is added for enabling or disabling each reporter level individually.cc @yao-msft
Microsoft Reviewers: Open in CodeFlow