Refactor PromptForPortableAliasIfApplicable method

microsoft · May 15, 2023 · b6bb8db · b6bb8db
1 parent 66e8e70
commit b6bb8db
Showing 1 changed file with 5 additions and 8 deletions.
diff --git a/src/WingetCreateCLI/Commands/NewCommand.cs b/src/WingetCreateCLI/Commands/NewCommand.cs
@@ -457,21 +457,18 @@ private static void PromptForPortableAliasIfApplicable(Installer installer)
 
                 if (!string.IsNullOrEmpty(portableCommandAlias))
                 {
-                    List<string> portableCommands = new List<string> { portableCommandAlias };
+                    List<string> portableCommands = new List<string> { portableCommandAlias.Trim() };
                     installer.Commands = portableCommands;
                 }
             }
 
             if (installer.NestedInstallerType == NestedInstallerType.Portable)
             {
-                foreach (NestedInstallerFile nestedInstallerFile in installer.NestedInstallerFiles)
-                {
-                    string portableCommandAlias = Prompt.Input<string>(Resources.PortableCommandAlias_Message);
+                string portableCommandAlias = Prompt.Input<string>(Resources.PortableCommandAlias_Message);
 
-                    if (!string.IsNullOrEmpty(portableCommandAlias))
-                    {
-                        nestedInstallerFile.PortableCommandAlias = portableCommandAlias;
-                    }
+                if (!string.IsNullOrEmpty(portableCommandAlias))
+                {
+                    installer.NestedInstallerFiles.First().PortableCommandAlias = portableCommandAlias.Trim();
                 }
             }
         }