Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wix not Differentiated from MSI #222

Closed
Trenly opened this issue Jan 27, 2022 · 0 comments · Fixed by #220
Closed

Wix not Differentiated from MSI #222

Trenly opened this issue Jan 27, 2022 · 0 comments · Fixed by #220
Labels
Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Resolution-Fix-Committed

Comments

@Trenly
Copy link
Contributor

Trenly commented Jan 27, 2022

Brief description of your issue

When a manifest with installer type 'wix' exists, attempting to update the package with new URLs fails as winget-create does not currently detect downloaded installers as wix

Steps to reproduce

  1. Find a package with installertype of wix
  2. Attempt to update it with winget-create
  3. get an error that url couldn't be matched to an installer

Expected behavior

The URL will be matched to an existing WIX installer

Actual behavior

wingetcreate update ChristianHohnstadt.xca -v 2.4.1 -u https://github.com/chris2511/xca/releases/download/RELEASE.2.4.0/xca-2.4.0.msi
Retrieving latest manifest for ChristianHohnstadt.xca
Downloading and parsing: https://github.com/chris2511/xca/releases/download/RELEASE.2.4.0/xca-2.4.0.msi...
Each new installer URL must have a single match to an existing installer based on installer type and architecture. The following installers failed to match an existing installer:
Multiple matches found for X64 Msi installer detected from the url: https://github.com/chris2511/xca/releases/download/RELEASE.2.4.0/xca-2.4.0.msi

- provided by @OfficialEsco

Environment

wingetcreate v0.4.4.1
@ghost ghost added the Needs-Triage label Jan 27, 2022
@ghost ghost added the In-PR label Jan 28, 2022
@denelon denelon added Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. and removed Needs-Triage labels Jan 29, 2022
@ghost ghost added Resolution-Fix-Committed and removed In-PR labels Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Resolution-Fix-Committed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants