Added WiX detection to MSI Parser. #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedieaston
requested review from
yao-msft and
ryfu-msft
and removed request for
a team
Trenly
reviewed
Jan 27, 2022
jedieaston
force-pushed
the
wix-me-if-you-need-me
branch
from
cb93aa3
to
c7776d6
Compare
jedieaston
force-pushed
the
wix-me-if-you-need-me
branch
from
c7776d6
to
a7b44c6
Compare
Trenly
approved these changes
Jan 27, 2022
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Component Governance down again? |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@jedieaston, can you file an issue relating to this change? Just want to make sure that every PR has a linked issue for tracking purposes. In the meantime, I'm looking into why the build is failing... |
|
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@jedieaston, sorry for the delay, took some time to figure out what was going on with Component Governance. You should be good to go now :) |
|
Looks like the changes from main are merged. Ready when you are :D |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Feb 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #222.
This PR adds WiX detection to the MSI Parser, inspired by similar changes to YamlCreate.ps1. Unfortuately, since there isn't a silver bullet way to determine if a MSI was created by WiX several things are checked.
Also, it seems to reformat PackageParser.cs for some reason, I suppose there was some style issue that was corrected during commit.
Tested: manually. As always, I'm happy to write unit tests if necessary.
Microsoft Reviewers: Open in CodeFlow