Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow change of installer type MSI => WIX #227

Open
Trenly opened this issue Feb 11, 2022 · 0 comments
Open

Allow change of installer type MSI => WIX #227

Trenly opened this issue Feb 11, 2022 · 0 comments
Assignees
Labels
Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work.

Comments

@Trenly
Copy link
Contributor

Trenly commented Feb 11, 2022

Description of the new feature / enhancement

There are several packages in the community repository with the installer type currently set to MSI incorrectly. Since the addition of #217 and #220, wingetcreate can now detect when an MSI file is actually built with WIX (thanks @jedieaston!) and will match the WIX installer to the MSI entry. However, this relies on the user to update the installer type themselves, even if wingetcreate can detect it reliably.

As a user, it would be nice if installer types would automatically be updated if the detected installer type is compatible with and more specific than the installer type already defined in the manifest. As an example, InstallerType of MSI could be changed to WIX, but WIX should not be changed to MSI. Similarly, EXE could be changed to INNO, NULLSOFT, or BURN, but not the other way around;

Proposed technical implementation details

No response

@Trenly Trenly added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Feb 11, 2022
@ghost ghost added the Needs-Triage label Feb 11, 2022
@ryfu-msft ryfu-msft self-assigned this Feb 11, 2022
@ghost ghost added the In-PR label Mar 1, 2022
@ghost ghost removed the In-PR label Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work.
Projects
None yet
2 participants