Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRLF line endings for all sources files #391

Closed
sandercox opened this issue Jun 23, 2023 · 0 comments · Fixed by #418
Closed

CRLF line endings for all sources files #391

sandercox opened this issue Jun 23, 2023 · 0 comments · Fixed by #418

Comments

@sandercox
Copy link
Contributor

Brief description of your issue

Trying to modify some code in the repo and doing a PR was almost impossible to get just my change to show. The file I tried to edit had mixed line endings.

Steps to reproduce

Try and open src/WingetCreateCLI/PromptHelper.cs with VS code and add /remove a line, make a commit and see that hundreds of lines have changed.

Expected behavior

After making a change and saving according to editorconfig settings, only my change is in the diff.

Maybe add a github action to have a double check on this policy such that no bad line endings end up in the source afterwards.

Actual behavior

All lines are reformatted in a decent editor creating messy PRs

Environment

-
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants