Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change LF line endings to CRLF in project files #418

Merged
merged 2 commits into from
Aug 7, 2023

Conversation

mdanish-kh
Copy link
Contributor

@mdanish-kh mdanish-kh commented Aug 2, 2023

I just did

Find: (?<!\r)\n
Replace: \r\n

across the whole project.

I understand some files may be auto-generated and these changes may get reverted in a new commit. Let me know if there are any here and if they should be excluded. Just highlighting the number of offending files with this commit.


Microsoft Reviewers: codeflow:open?pullrequest=https://github.com/microsoft/winget-create/pull/418&drop=dogfoodAlpha

@mdanish-kh mdanish-kh requested a review from a team as a code owner August 2, 2023 17:24
@mdanish-kh mdanish-kh requested review from yao-msft and ryfu-msft and removed request for a team August 2, 2023 17:24
@mdanish-kh
Copy link
Contributor Author

mdanish-kh commented Aug 2, 2023

I realized I could've probably done

dotnet format src\WingetCreateCLI.sln --no-restore (Ref: https://learn.microsoft.com/en-us/dotnet/core/tools/dotnet-format)

to enforce the .editorconfig settings across the whole solution. But the resulting output for the line endings is the same for both operations. Just that the dotnet format adds an additional formatting fix for Program.cs. I've run the command and added changes from it in the new commit.

@ryfu-msft
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ryfu-msft ryfu-msft merged commit ef2c2e7 into microsoft:main Aug 7, 2023
4 checks passed
@mdanish-kh mdanish-kh deleted the lineEndings branch August 7, 2023 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CRLF line endings for all sources files
2 participants