Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add interactive update feature #149

Merged
merged 9 commits into from
Sep 7, 2021
Merged

Add interactive update feature #149

merged 9 commits into from
Sep 7, 2021

Conversation

ryfu-msft
Copy link
Contributor

@ryfu-msft ryfu-msft commented Sep 1, 2021

Resolves #118
Resolves #120
Resolves #142

This PR adds the following changes:

  • Adds an --interactive flag to allow users to interactively specify which installer they want to update.
  • This feature is not autonomously and not meant to be used in a CI/CD scenario, but rather as a way to handle any update mismatches.
  • Refactored update flow in preparation for any additional changes to the interactive flow.
Microsoft Reviewers: Open in CodeFlow

@ryfu-msft ryfu-msft requested a review from a team as a code owner September 1, 2021 17:01
@ghost ghost added the Issue-Bug label Sep 1, 2021
@ryfu-msft
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft microsoft deleted a comment from azure-pipelines bot Sep 1, 2021
@microsoft microsoft deleted a comment from azure-pipelines bot Sep 1, 2021
@microsoft microsoft deleted a comment from azure-pipelines bot Sep 1, 2021
src/WingetCreateCLI/Commands/UpdateCommand.cs Outdated Show resolved Hide resolved
src/WingetCreateCLI/Commands/UpdateCommand.cs Show resolved Hide resolved
src/WingetCreateCLI/Commands/UpdateCommand.cs Show resolved Hide resolved
src/WingetCreateCLI/Properties/Resources.resx Outdated Show resolved Hide resolved
src/WingetCreateCLI/Properties/Resources.resx Show resolved Hide resolved
src/WingetCreateCore/Common/PackageParser.cs Outdated Show resolved Hide resolved
src/WingetCreateCore/Common/PackageParser.cs Outdated Show resolved Hide resolved
@ghost ghost added the Needs-Author-Feedback label Sep 2, 2021
@ghost ghost removed the Needs-Author-Feedback label Sep 3, 2021
@ryfu-msft ryfu-msft merged commit 6f160c9 into main Sep 7, 2021
@ryfu-msft ryfu-msft deleted the interactiveUpdate branch September 7, 2021 21:51
@Yamartim
Copy link

Yamartim commented Sep 8, 2021

Hello! I'm a bit new to github sorry if this is a dumb question but is this --interactive flag actually usable or documented in anyway yet? I want to update the LibRetro.RetroArch package but it runs into the problem described in #118.
If it isn't usable yet, when will it be available and documented?
(by available I mean easily obtainable through winget upgrade wingetcreate, compiling from source really isn't something I can resort to right now 😅)
Thank you!

@denelon
Copy link
Contributor

denelon commented Sep 8, 2021

https://docs.microsoft.com/windows/package-manager/winget/install

The interactive flag essentially runs the installer without passing silent or silent with progress switches to the installer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants