Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove fields with empty strings from manifest output #208

Merged
merged 1 commit into from
Dec 6, 2021
Merged

Remove fields with empty strings from manifest output #208

merged 1 commit into from
Dec 6, 2021

Conversation

ryfu-msft
Copy link
Contributor

@ryfu-msft ryfu-msft commented Dec 6, 2021 •
edited
Loading

Changes:

  • Checks string fields to see if they have empty string values and convert them into null so that they do not get published in the generated manifest.

Tests:

  • Added UpdateWithEmptyFields test to verify that the empty string fields of a manifest are removed prior to being published.
Microsoft Reviewers: Open in CodeFlow

@ryfu-msft ryfu-msft requested a review from a team as a code owner December 6, 2021 23:25
@ghost ghost added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Dec 6, 2021
@ryfu-msft ryfu-msft merged commit 7742e43 into main Dec 6, 2021
@ryfu-msft ryfu-msft deleted the productCodeValidation branch December 6, 2021 23:59
@ryfu-msft ryfu-msft mentioned this pull request Dec 7, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChuckFerring-zz ChuckFerring-zz ChuckFerring-zz approved these changes

Assignees
No one assigned
Labels
Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ryfu-msft @ChuckFerring-zz