Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for creating and updating portable manifests #290

Merged
merged 9 commits into from
Aug 3, 2022
Merged

Add support for creating and updating portable manifests #290

merged 9 commits into from
Aug 3, 2022

Conversation

ryfu-msft
Copy link
Contributor

@ryfu-msft ryfu-msft commented Jul 22, 2022 •
edited by ghost
Loading

Resolves #278

Changes:

  • If parsing detects that the installer is an exe installerType, winget-create will now prompt the user asking if this is a portable package, then ask related portable metadata.
  • Added Installertype.Portable to the compatibility set for exe. This ensures that the portable installertype will be preserved when updating a manifest.

Tests:

  • Verified portable prompts manually to ensure that it works
  • Added E2E test for submitting a portable manifest
  • Added a unit test for updating a portable manifest.
Microsoft Reviewers: Open in CodeFlow

@ryfu-msft ryfu-msft requested a review from a team as a code owner July 22, 2022 21:56
@ryfu-msft ryfu-msft requested review from yao-msft and removed request for a team July 22, 2022 21:56
@ghost ghost added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Jul 22, 2022
@ItzLevvie ItzLevvie mentioned this pull request Aug 2, 2022
Closed
@ryfu-msft ryfu-msft merged commit 99cc214 into microsoft:main Aug 3, 2022
@ryfu-msft ryfu-msft deleted the parsePortable branch August 3, 2022 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yao-msft yao-msft yao-msft approved these changes

Assignees
No one assigned
Labels
Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update winget-create parsing logic to detect portable apps
2 participants
@ryfu-msft @yao-msft