Update cache command to handle directories
#360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdanish-kh
requested review from
yao-msft and
ryfu-msft
and removed request for
a team
mdanish-kh
force-pushed
the
handleCachedDirectories
branch
from
bd0545f
to
acc3a76
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ryfu-msft
reviewed
Apr 25, 2023
|
Ah I should have mentioned this before, you only need to edit the file |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The implementation of zip installers meant that winget-create now extracts the zip archives to
%LOCALAPPDATA%\Temp\wingetcreate. The extracted directories are not shown inwingetcreate cache --listand not removed bywingetcreate cache --clean. This PR aims to fix the behavior by listing and removing the extracted folders in the respectivewingetcreate cachecommands.Description
DirectoriesFound_Messageto show in cache --list/or\(depending on the OS)When deleting the directories, I used the same message for deleting installers i.e.,Renamed the existing resource string fromDeletingInstaller_Messageas I didn't feel the need to create a new string for it.DeletingInstaller_Message->DeletingItem_Messageto be more generic to cater for deletion of directories as wellMicrosoft Reviewers: Open in CodeFlow