Prevent re-downloads from same InstallerUrl #381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdanish-kh
requested review from
yao-msft and
ryfu-msft
and removed request for
a team
mdanish-kh
force-pushed
the
cacheDownloads
branch
2 times, most recently
from
b5b9e75
to
27992be
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves Allow updating a manifest with a different number of installer URLs #291 (comment) (use case described in this comment). Some test packages for this change are ChidiWilliams.Buzz (~200 MB installer), Kiwix.Wikivoyage.Electron (~800 MB installer), JanDeDobbeleer.OhMyPosh in upgrade command
This also seems to resolve Cannot download duplicate installer file in interactive mode update (v1.2.5.0) #344 as now we're not calling PackageParser.DownloadFileAsync() where the error occurs for a duplicate InstallerUrl. I've commented Steps to reproduce / test packages in the linked issue.
Microsoft Reviewers: Open in CodeFlow