Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for removing temporary files #427

Merged
merged 7 commits into from
Aug 23, 2023

Conversation

mdanish-kh
Copy link
Contributor

@mdanish-kh mdanish-kh commented Aug 11, 2023

Also added a user setting to control the cleanup process. Chose 7-day interval as the default to be consistent with microsoft/winget-cli#3434


Microsoft Reviewers: codeflow:open?pullrequest=https://github.com/microsoft/winget-create/pull/427&drop=dogfoodAlpha

@mdanish-kh mdanish-kh requested a review from a team as a code owner August 11, 2023 19:32
@mdanish-kh mdanish-kh requested review from yao-msft and ryfu-msft and removed request for a team August 11, 2023 19:32
@microsoft-github-policy-service microsoft-github-policy-service bot added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Aug 11, 2023
Copy link
Contributor

@ryfu-msft ryfu-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super neat addition, just a few comments :)

doc/settings.md Show resolved Hide resolved
src/WingetCreateCLI/Common.cs Outdated Show resolved Hide resolved
@ryfu-msft
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ryfu-msft ryfu-msft merged commit bc99df6 into microsoft:main Aug 23, 2023
4 checks passed
@mdanish-kh mdanish-kh deleted the cleanUp branch August 23, 2023 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up log files and installer cache directory
3 participants