Fix pattern for getting same name files #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdanish-kh
requested review from
yao-msft and
ryfu-msft
and removed request for
a team
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
This just needs a re-run it seems |
|
Ok tonrun on fresh win11..!?
man. 25. sep. 2023, 19:08 skrev Muhammad Danish ***@***.***>:
… This just needs a re-run it seems
—
Reply to this email directly, view it on GitHub
<#455 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AQDX3BWLMNSWU7FJ6UTG2ATX4G3BRANCNFSM6AAAAAA5FFBNEA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ryfu-msft
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure why/how but the call to
Path.ChangeExtension()incorrectly modifies the file name for some files.Instead of returning expected pattern
Thunderbird%20Setup%20102.6.0*(for actual file nameThunderbird%20Setup%20102.6.0.msi), it returnsThunderbird%20Setup%20102.6.msi(truncating the '0' instead of the extension)To fix this, manually concatenated the strings to form a matching pattern.
Validation
Run
wingetcreate update Mozilla.Thunderbird --version 102.6.0 -iMicrosoft Reviewers: Open in CodeFlow