Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prototype creating a WinGet Configuration DSC file in PowerShell #462

Merged
merged 6 commits into from
Dec 4, 2023

Conversation

KevinLaMS
Copy link
Contributor

@KevinLaMS KevinLaMS commented Oct 25, 2023


Creating DSC files can be a challenge.
This script tries to make it easier by leveraging winget search to locate the packages, and then write the file out as YAML.

Microsoft Reviewers: Open in CodeFlow

@KevinLaMS
Copy link
Contributor Author

#458 @Trenly your feedback would be appreciated too.

src/prototype/WingetCreateMakeDSC.ps1 Outdated Show resolved Hide resolved
src/prototype/WingetCreateMakeDSC.ps1 Outdated Show resolved Hide resolved
src/prototype/WingetCreateMakeDSC.ps1 Outdated Show resolved Hide resolved
src/prototype/WingetCreateMakeDSC.ps1 Outdated Show resolved Hide resolved
src/prototype/WingetCreateMakeDSC.ps1 Outdated Show resolved Hide resolved
src/prototype/WingetCreateMakeDSC.ps1 Outdated Show resolved Hide resolved
src/prototype/WingetCreateMakeDSC.ps1 Outdated Show resolved Hide resolved
@KevinLaMS
Copy link
Contributor Author

@Trenly @mdanish-kh

  1. Thanks for the feedback. I have tried to implement.
  2. I resolved the threads, but in retrospect, I probably should have let you do that. Sorry.
  3. Menace me some more, if I messed up your recommendations.

Copy link
Contributor

@mdanish-kh mdanish-kh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KevinLaMS

I resolved the threads, but in retrospect, I probably should have let you do that. Sorry.

GitHub allows only the PR author or users with write access to resolve threads, so you did the right thing ☺️

Menace me some more, if I messed up your recommendations.

Did some more menacing😄Most are nits that we can choose to leave and iterate upon them after merging in this PR

src/prototype/WingetCreateMakeDSC.ps1 Outdated Show resolved Hide resolved
src/prototype/WingetCreateMakeDSC.ps1 Outdated Show resolved Hide resolved
src/prototype/WingetCreateMakeDSC.ps1 Outdated Show resolved Hide resolved
src/prototype/WingetCreateMakeDSC.ps1 Outdated Show resolved Hide resolved
src/prototype/WingetCreateMakeDSC.ps1 Outdated Show resolved Hide resolved
src/prototype/WingetCreateMakeDSC.ps1 Outdated Show resolved Hide resolved
src/prototype/WingetCreateMakeDSC.ps1 Outdated Show resolved Hide resolved
src/prototype/WingetCreateMakeDSC.ps1 Outdated Show resolved Hide resolved
@Trenly Trenly mentioned this pull request Dec 2, 2023
2 tasks
@ryfu-msft ryfu-msft marked this pull request as ready for review December 4, 2023 21:49
@ryfu-msft ryfu-msft requested a review from a team as a code owner December 4, 2023 21:49
@ryfu-msft ryfu-msft requested review from yao-msft and ryfu-msft and removed request for a team December 4, 2023 21:49
@ryfu-msft ryfu-msft merged commit 08baf0e into main Dec 4, 2023
2 checks passed
@ryfu-msft ryfu-msft deleted the MakeDSC branch December 4, 2023 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants