Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand environment variables in input paths #484

Merged
merged 2 commits into from
Nov 27, 2023
Merged

Expand environment variables in input paths #484

merged 2 commits into from
Nov 27, 2023

Conversation

mdanish-kh
Copy link
Contributor

@mdanish-kh mdanish-kh commented Nov 25, 2023 •
edited by microsoft-github-policy-service bot
Loading

Path.GetFullPath() will convert any slashes to Path.DirectorySeparatorChar which is backslash in Windows. This is done to make sure that when user gives a command wingetcreate update xyz --out %USERPROFILE%/Desktop, then the output path on the CLI is printed with consistent slashes as

Manifest saved to %USERPROFILE%\Desktop\manifests\xyz\version\

otherwise it will be printed as %USERPROFILE%/Desktop\manifests\xyz\version

Microsoft Reviewers: Open in CodeFlow

@mdanish-kh mdanish-kh requested a review from a team as a code owner November 25, 2023 20:27
@mdanish-kh mdanish-kh requested review from yao-msft and ryfu-msft and removed request for a team November 25, 2023 20:27
@microsoft-github-policy-service microsoft-github-policy-service bot added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Nov 25, 2023
@ryfu-msft
Copy link
Contributor

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ryfu-msft ryfu-msft merged commit ad06a4e into microsoft:main Nov 27, 2023
3 of 5 checks passed
@mdanish-kh mdanish-kh deleted the expandPaths branch November 28, 2023 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryfu-msft ryfu-msft ryfu-msft approved these changes

@yao-msft yao-msft Awaiting requested review from yao-msft yao-msft is a code owner automatically assigned from microsoft/oca

Assignees
No one assigned
Labels
Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

WingetCreate commands should work with anonymized paths
2 participants
@mdanish-kh @ryfu-msft