-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use latest project dependencies #512
Conversation
For updating all the package dependencies, we may need some internal reviews to determine which versions to use. For example, we may prefer versions with long term support instead of the latest. We may need to do some e2e validation. And may need to check dependencies align with related other parts of winget. |
I hope it gets merged before the release which will be done as soon as support for 1.6..0 manifests will be added. |
Is there a particular reason we need to use latest for 1.6 release? |
There are a few enhancements I plan to do with |
Ah, thanks for the explanation. Really sorry and unfortunately we kicked off release build right after Ryan merged the 1es pipeline fix. This will be winget 1.7. Or if it's strongly desired, we could make a 1.6 servicing release for this. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
I kicked off a new release so that we can start supporting 1.6 manifests. I can cut another release after we get this checked in. I am just wary of upgrading lots of dependencies all at once as I'm not sure what will break so I want to take our time with this. |
No problem. I also see the pipelines have failed at "run tests" step. Will take a look where is problem occurring. |
I've verified now that all tests pass (locally). Please re-run the pipelines. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also address the build warnings for nlog as some of the old implementation is now obsolete: https://dev.azure.com/ms/winget-create/_build/results?buildId=543915&view=logs&j=98381272-e9a2-5a3f-96d0-ae584d124b68&t=75922424-0f44-52d3-ca52-3450e0e3619b&l=11937
Maybe this can help you: NLog/NLog#4782
Co-authored-by: Ryan <69221034+ryfu-msft@users.noreply.github.com>
@vedantmgoyal2009, please resolve conflicts, then I'll run the pipeline again. The rest looks good to me |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Pipelines passed (@yao-msft @ryfu-msft) |
@yao-msft @ryfu-msft @mdanish-kh
Microsoft Reviewers: Open in CodeFlow