Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use latest project dependencies #512

Merged
merged 10 commits into from
Feb 20, 2024

Conversation

vedantmgoyal9
Copy link
Contributor

@vedantmgoyal9 vedantmgoyal9 commented Feb 14, 2024


  • Upgraded all dependencies.
  • Fixed errors due to "breaking changes" in dependencies.
  • Ran code cleanup.

@yao-msft @ryfu-msft @mdanish-kh

Microsoft Reviewers: Open in CodeFlow

@vedantmgoyal9 vedantmgoyal9 requested a review from a team as a code owner February 14, 2024 21:19
@vedantmgoyal9 vedantmgoyal9 requested review from yao-msft and ryfu-msft and removed request for a team February 14, 2024 21:19
@yao-msft
Copy link

For updating all the package dependencies, we may need some internal reviews to determine which versions to use. For example, we may prefer versions with long term support instead of the latest. We may need to do some e2e validation. And may need to check dependencies align with related other parts of winget.

@vedantmgoyal9
Copy link
Contributor Author

vedantmgoyal9 commented Feb 14, 2024

I hope it gets merged before the release which will be done as soon as support for 1.6..0 manifests will be added.

@yao-msft
Copy link

I hope it gets merged before the release which will be done as soon as support for 1.6..0 manifests will be added.

Is there a particular reason we need to use latest for 1.6 release?

@vedantmgoyal9
Copy link
Contributor Author

There are a few enhancements I plan to do with update command so that it can perform advanced installer-and-url matches, which will enable wingetcreate to be used in automation scenarios. Using latest libraries will be a great help, as many of the dependencies have breaking changes, and the documentation for old versions is hard to find, unless they have versioned documentation which is in track with the releases of the library.

@yao-msft
Copy link

There are a few enhancements I plan to do with update command so that it can perform advanced installer-and-url matches, which will enable wingetcreate to be used in automation scenarios. Using latest libraries will be a great help, as many of the dependencies have breaking changes, and the documentation for old versions is hard to find, unless they have versioned documentation which is in track with the releases of the library.

Ah, thanks for the explanation. Really sorry and unfortunately we kicked off release build right after Ryan merged the 1es pipeline fix. This will be winget 1.7. Or if it's strongly desired, we could make a 1.6 servicing release for this.

@ryfu-msft
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ryfu-msft
Copy link
Contributor

There are a few enhancements I plan to do with update command so that it can perform advanced installer-and-url matches, which will enable wingetcreate to be used in automation scenarios. Using latest libraries will be a great help, as many of the dependencies have breaking changes, and the documentation for old versions is hard to find, unless they have versioned documentation which is in track with the releases of the library.

I kicked off a new release so that we can start supporting 1.6 manifests.

I can cut another release after we get this checked in. I am just wary of upgrading lots of dependencies all at once as I'm not sure what will break so I want to take our time with this.

@vedantmgoyal9
Copy link
Contributor Author

No problem. I also see the pipelines have failed at "run tests" step. Will take a look where is problem occurring.

@vedantmgoyal9
Copy link
Contributor Author

I've verified now that all tests pass (locally). Please re-run the pipelines.

@ryfu-msft
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@ryfu-msft ryfu-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also address the build warnings for nlog as some of the old implementation is now obsolete: https://dev.azure.com/ms/winget-create/_build/results?buildId=543915&view=logs&j=98381272-e9a2-5a3f-96d0-ae584d124b68&t=75922424-0f44-52d3-ca52-3450e0e3619b&l=11937

Maybe this can help you: NLog/NLog#4782

src/WingetCreateCLI/Commands/UpdateCommand.cs Outdated Show resolved Hide resolved
src/WingetCreateCLI/PromptHelper.cs Outdated Show resolved Hide resolved
src/WingetCreateCLI/PromptHelper.cs Outdated Show resolved Hide resolved
Co-authored-by: Ryan <69221034+ryfu-msft@users.noreply.github.com>
@ryfu-msft
Copy link
Contributor

@vedantmgoyal2009, please resolve conflicts, then I'll run the pipeline again. The rest looks good to me

@ryfu-msft
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ryfu-msft
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@vedantmgoyal9
Copy link
Contributor Author

Pipelines passed (@yao-msft @ryfu-msft)

@ryfu-msft ryfu-msft merged commit fcc5e64 into microsoft:main Feb 20, 2024
5 checks passed
@vedantmgoyal9 vedantmgoyal9 deleted the use-latest-deps branch February 20, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants