Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Unwanted software bundled with Estmob.SendAnywhere #47643

Closed
u254254 opened this issue Feb 22, 2022 · 10 comments
Closed

[Bug]: Unwanted software bundled with Estmob.SendAnywhere #47643

u254254 opened this issue Feb 22, 2022 · 10 comments
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation.
Milestone

Comments

@u254254
Copy link

u254254 commented Feb 22, 2022

Brief description of your issue

When installing Estmob.SendAnywhere, unwanted software called 'Gicon' is bundled that is for showing an ad. It is optional and unchecked in install screen. but in quiet install by winget, it is installed without any prompt.

Steps to reproduce

  1. Install Estmob.SendAnywhere by winget.
  2. Press Yes in UAC. (I don't know what happen in press No in UAC)

Expected behavior

No unwanted software.

Actual behavior

Installs unwanted software called 'Gicon'

Environment

Windows Package Manager v1.1.13405
Windows: Windows.Desktop v10.0.19044.1526
Package: Microsoft.DesktopAppInstaller v1.16.13405.0
@u254254 u254254 added the Issue-Bug It either shouldn't be doing this or needs an investigation. label Feb 22, 2022
@ghost ghost added the Needs-Triage This work item needs to be triaged by a member of the core team. label Feb 22, 2022
@OfficialEsco
Copy link
Contributor

These are the only options i can see when running it manually?
VirtualBoxVM_sBVzx0Lwna

And no Gicon software installed
VirtualBoxVM_XSiravHGAE

Reset VM

PS M:\> winget install Estmob.SendAnywhere
Found Send Anywhere [Estmob.SendAnywhere] Version 21.4.211415
This application is licensed to you by its owner.
Microsoft is not responsible for, nor does it grant any licenses to, third-party packages.
Downloading https://update.send-anywhere.com/downloads/x64/SendAnywhereSetup.exe
  ██████████████████████████████  94.9 MB / 94.9 MB
Successfully verified installer hash
Starting package install...
Successfully installed

Still no Gicon software
VirtualBoxVM_kMSX2fhsVI

@denelon denelon added Needs-Author-Feedback This needs a response from the author. and removed Needs-Triage This work item needs to be triaged by a member of the core team. labels Feb 22, 2022
@denelon
Copy link
Contributor

denelon commented Feb 22, 2022

I have also not been able to reproduce this.

@u254254 can you replicate this and share logs? The log location is visible via winget --info.

@u254254
Copy link
Author

u254254 commented Feb 24, 2022

I tested manual install in fresh VM (English and Korean). in English Windows, no 'Smart Search' component showing and no Gicon installed. in Korean Windows, Smart Search component shows and installs Gicon.


Test Images

English Korean
No 'Smart Search' component install_ko
No Gicon installed gicon_installed
Installed with WinGet: gicon_installed_winget

WinGet logs (Korean Windows): WinGet logs.zip

Plus: It registers itself into Task Scheduler:
Gicon Scheduler

@OfficialEsco
Copy link
Contributor

And both times you used https://update.send-anywhere.com/downloads/x64/SendAnywhereSetup.exe ?
So the bad thing about Closed source Nullsoft and Inno installers is that we cannot know their custom switches, aka we cannot disable it when the evil Developer enabled it by default..

@u254254 u254254 closed this as completed Feb 24, 2022
@denelon denelon reopened this Feb 24, 2022
@denelon
Copy link
Contributor

denelon commented Feb 24, 2022

I think we need to remove this package since it includes unwanted software. I'll start looking at possible solutions for this.
@OfficialEsco do you have any suggestions?

@OfficialEsco
Copy link
Contributor

I do not, i've never seen a package act differently under a different locale, i believe this is a Korean/Chinese issue...
We can force it to be Interactive only? Or add a warning to the Korean InstallerLocale/Locale?

@denelon
Copy link
Contributor

denelon commented Feb 24, 2022

We need to test to see if Gicon flags as PUA. I've asked the team to confirm and run scans. If it is detected as PUA, we will remove it from the repository.

@denelon denelon added Needs: Attention and removed Needs-Author-Feedback This needs a response from the author. labels Feb 24, 2022
@denelon
Copy link
Contributor

denelon commented Feb 24, 2022

#23473

@SpecterShell
Copy link
Contributor

SpecterShell commented Feb 25, 2022

There is no switch to uncheck NSIS section and I didn't see any custom switches available.
Anyway, there are two ways to bypass it manually:

  1. Block www.wizchat.co.kr in Firewall
  2. Put something to %APPDATA%\msafespt\msafespt.exe
Function .onInit
  ; ...
  StrCmp $LANGUAGE 1042 label_1084 ; If is Korean, jump to label_1084
  Push $R0
  Push $R1
  StrCpy $R1 5
  SectionGetFlags $R1 $R0
  IntOp $R0 $R0 & 0xFFFFFFFE ; https://nsis-dev.github.io/NSIS-Forums/html/t-143655.html
  SectionSetFlags $R1 $R0 ; Force uncheck "Smart Search"
  SectionSetText $R1 "" ; Hide "Smart Search"
  Pop $R1
  Pop $R0
label_1084:
  IfFileExists $APPDATA\msafespt\msafespt.exe 0 label_1086 ; If file exists, hide "Smart Search"
  SectionSetText 5 ""
label_1086:
  ; ...
FunctionEnd

I do not, i've never seen a package act differently under a different locale, i believe this is a Korean/Chinese issue... We can force it to be Interactive only? Or add a warning to the Korean InstallerLocale/Locale?

It only appears in Korean.
You can duplicate installer item and add

  InstallerLocale: ko-KR
  InstallerSwitches:
    Silent: # Anything other than /S
    SilentWithProgress: # Anything other than /S

In this way it will not be silent for Korean users.

@denelon
Copy link
Contributor

denelon commented Aug 18, 2022

We have added a task with @msftbot to add "Blocking-Issue" to PRs for this package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation.
Projects
None yet
Development

No branches or pull requests

6 participants