-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Unwanted software bundled with Estmob.SendAnywhere #47643
Comments
I have also not been able to reproduce this. @u254254 can you replicate this and share logs? The log location is visible via |
I tested manual install in fresh VM (English and Korean). in English Windows, no 'Smart Search' component showing and no Gicon installed. in Korean Windows, Smart Search component shows and installs Gicon. Test Images
WinGet logs (Korean Windows): WinGet logs.zip |
And both times you used https://update.send-anywhere.com/downloads/x64/SendAnywhereSetup.exe ? |
I think we need to remove this package since it includes unwanted software. I'll start looking at possible solutions for this. |
I do not, i've never seen a package act differently under a different locale, i believe this is a Korean/Chinese issue... |
We need to test to see if Gicon flags as PUA. I've asked the team to confirm and run scans. If it is detected as PUA, we will remove it from the repository. |
There is no switch to uncheck NSIS section and I didn't see any custom switches available.
Function .onInit
; ...
StrCmp $LANGUAGE 1042 label_1084 ; If is Korean, jump to label_1084
Push $R0
Push $R1
StrCpy $R1 5
SectionGetFlags $R1 $R0
IntOp $R0 $R0 & 0xFFFFFFFE ; https://nsis-dev.github.io/NSIS-Forums/html/t-143655.html
SectionSetFlags $R1 $R0 ; Force uncheck "Smart Search"
SectionSetText $R1 "" ; Hide "Smart Search"
Pop $R1
Pop $R0
label_1084:
IfFileExists $APPDATA\msafespt\msafespt.exe 0 label_1086 ; If file exists, hide "Smart Search"
SectionSetText 5 ""
label_1086:
; ...
FunctionEnd
It only appears in Korean. InstallerLocale: ko-KR
InstallerSwitches:
Silent: # Anything other than /S
SilentWithProgress: # Anything other than /S In this way it will not be silent for Korean users. |
We have added a task with @msftbot to add "Blocking-Issue" to PRs for this package. |
Brief description of your issue
When installing
Estmob.SendAnywhere
, unwanted software called 'Gicon' is bundled that is for showing an ad. It is optional and unchecked in install screen. but in quiet install by winget, it is installed without any prompt.Steps to reproduce
Estmob.SendAnywhere
by winget.Expected behavior
No unwanted software.
Actual behavior
Installs unwanted software called 'Gicon'
Environment
The text was updated successfully, but these errors were encountered: