Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New package: EstMob.SendAnywhere version 24.3.80853 #152766

Merged
merged 5 commits into from
May 13, 2024
Merged

New package: EstMob.SendAnywhere version 24.3.80853 #152766

merged 5 commits into from
May 13, 2024

Conversation

alexkoala
Copy link
Contributor

@alexkoala alexkoala commented May 8, 2024 •
edited by microsoft-github-policy-service bot
Loading

Checklist for Pull Requests

Manifests

  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.6 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Replacing #149761

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot added the Package-Flagged Package needs further validation ensuring compliance with repository policies label May 8, 2024
@alexkoala
Copy link
Contributor Author

Send Anywhere no longer installs PUA. It only asks install path.
image

Send Anywhere had a problem installing PUA when quiet install through winget if the language was set to ko-KR. (#47643) However, during a recent installation, I noticed that the PUA-related part was completely deleted from installer.

Trenly
Trenly suggested changes May 9, 2024
View reviewed changes
Copy link
Contributor

@Trenly Trenly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@u254254 - As you were the user who originally filed the issue around the PUA in the Korean unattended install, would you be able to verify whether downloading the installer and running it from PowerShell using ./SendAnywhereSetup.exe /S works to install just SendAnywhere and not the PUA?

cc @SpecterShell as they were somehow able to find the NSIS script the older version of the installer used

...akutenSymphonyKorea/SendAnywhere/24.3.80853/RakutenSymphonyKorea.SendAnywhere.installer.yaml Outdated Show resolved Hide resolved
...tenSymphonyKorea/SendAnywhere/24.3.80853/RakutenSymphonyKorea.SendAnywhere.locale.en-US.yaml Outdated Show resolved Hide resolved
manifests/r/RakutenSymphonyKorea/SendAnywhere/24.3.80853/RakutenSymphonyKorea.SendAnywhere.yaml Outdated Show resolved Hide resolved
...tenSymphonyKorea/SendAnywhere/24.3.80853/RakutenSymphonyKorea.SendAnywhere.locale.en-US.yaml Outdated Show resolved Hide resolved
...tenSymphonyKorea/SendAnywhere/24.3.80853/RakutenSymphonyKorea.SendAnywhere.locale.en-US.yaml Outdated Show resolved Hide resolved
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Author-Feedback This needs a response from the author. Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels May 9, 2024
@alexkoala @Trenly
Apply suggestions from code review
975f583 
Co-authored-by: Kaleb Luedtke <trenlymc@gmail.com>
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed Needs-Attention This work item needs to be reviewed by a member of the core team. Changes-Requested Changes Requested labels May 9, 2024
@wingetbot wingetbot added the Manifest-Validation-Error Manifest validation failed label May 9, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label May 9, 2024
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed Manifest-Validation-Error Manifest validation failed Needs-Author-Feedback This needs a response from the author. labels May 9, 2024
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the PullRequest-Error PR is Invalid label May 9, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label May 9, 2024
@alexkoala alexkoala changed the title New package: RakutenSymphonyKorea.SendAnywhere version 24.3.80853 New package: EstMob.SendAnywhere version 24.3.80853 May 9, 2024
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed Needs-Author-Feedback This needs a response from the author. PullRequest-Error PR is Invalid labels May 9, 2024
@wingetbot wingetbot added New-Package Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels May 9, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot enabled auto-merge (squash) May 9, 2024 01:54
@Trenly
Copy link
Contributor

Trenly commented May 9, 2024

I did test in a VM set to ko-KR locale and didn't see any PUA installed, so I'm inclined to believe the ISV did remove it. However, I'd like to wait a bit to see if @u254254 responds. I'd also like to discuss this with @denelon as this is the first Flagged Package which could potentially be unflagged, and I want to be certain that it is thoroughly tested and complies with all the WinGet policies

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Review This work item needs to be reviewed by a member of another team. label May 9, 2024
@denelon
Copy link
Contributor

denelon commented May 9, 2024

As long as the PUA has been removed, I'm fine bringing this package back.

@SpecterShell
Copy link
Contributor

cc @SpecterShell as they were somehow able to find the NSIS script the older version of the installer used

The part of NSIS script that installs the PUA appears to have been removed from the latest installer.

@Trenly
Copy link
Contributor

Trenly commented May 13, 2024

[Policy] Reset Labels

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs-Review This work item needs to be reviewed by a member of another team. label May 13, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label May 13, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot merged commit b5b6438 into microsoft:master May 13, 2024
8 checks passed
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

@alexkoala alexkoala deleted the RakutenSymphonyKorea.SendAnywhere-24.3.80853 branch May 14, 2024 06:46
@Trenly Trenly mentioned this pull request May 18, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@microsoft-github-policy-service microsoft-github-policy-service[bot] microsoft-github-policy-service[bot] approved these changes

@Trenly Trenly Trenly approved these changes

Assignees
No one assigned
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR New-Package Package-Flagged Package needs further validation ensuring compliance with repository policies Publish-Pipeline-Succeeded Validation-Completed Validation passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@alexkoala @wingetbot @Trenly @denelon @SpecterShell @stephengillie