Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AntonyCourtney.Tad version 0.12.0 #101827

Merged
merged 2 commits into from
Apr 7, 2023
Merged

AntonyCourtney.Tad version 0.12.0 #101827

merged 2 commits into from
Apr 7, 2023

Conversation

dpprdan
Copy link
Contributor

@dpprdan dpprdan commented Apr 7, 2023

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.4 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided. label Apr 7, 2023
@microsoft-github-policy-service
Copy link
Contributor

Hello @dpprdan,

During installation testing, this application failed to install without user input. Did you forget to add Silent or SilentWithProgress switches?

This can also happen when a dependency is missing. You can test with https://github.com/microsoft/winget-pkgs#test-your-manifest.

Please investigate a fix and resubmit the Pull Request.

You may also try using the Windows Package Manager Manifest Creator to determine the proper installer type. If the installer type is MSIX, MSI, or a known installer technology like NullSoft, Inno, etc. the wingetcreate tool can detect them and the winget client will know what switches to pass. If it's a .exe installer of an unknown type, you will need to search to determine the proper switches for Silent and SilentWithProgress.

Template: msftbot/validationError/installation/unattended

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@microsoft-github-policy-service microsoft-github-policy-service bot removed Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided. Needs-Author-Feedback This needs a response from the author. labels Apr 7, 2023
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Apr 7, 2023
@microsoft-github-policy-service
Copy link
Contributor

dpprdan,

The check-in policies require a moderator to approve PRs from the community.

Our moderators are community volunteers, please be patient and allow them sufficient time to review your submission.

Template: msftbot/requiresApproval/moderator

@dpprdan
Copy link
Contributor Author

dpprdan commented Apr 7, 2023

@Trenly: wingetcreate apparently did not detect that the architecture is x64 not x86 (again, as you corrected the PR for the last version). Can you tell if this due to some misconfiguration in the Tad installer or a bug in wingetcreate that should be filed there?

Maybe related to microsoft/winget-create#329?

@Trenly
Copy link
Contributor

Trenly commented Apr 7, 2023

@Trenly: wingetcreate apparently did not detect that the architecture is x64 not x86 (again, as you corrected the PR for the last version). Can you tell if this due to some misconfiguration in the Tad installer or a bug in wingetcreate that should be filed there?

Maybe related to microsoft/winget-create#329?

Wingetcreate looks at the installer's architecture to try and determine which it is. In this case, the installer is compiled for x86, even though the application inside will only run on x64

There are a few ways to work around this.

  1. Manually update after manifest creation
  2. The publisher can update the installer URL to include _x64
  3. You can use the architecture override syntax

@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Apr 7, 2023
@microsoft-github-policy-service
Copy link
Contributor

Hello dpprdan,
Validation has completed.

Template: msftbot/validationCompleted

@microsoft-github-policy-service microsoft-github-policy-service bot merged commit 0497ef3 into microsoft:master Apr 7, 2023
@dpprdan dpprdan deleted the autogenerated/AntonyCourtney.Tad/e77b60b2-f763-40a8-9144-c9dd69da9847 branch April 7, 2023 20:07
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR Publish-Pipeline-Succeeded Validation-Completed Validation passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants