Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: Microsoft.ServiceFabricSDK version 7.0.1816 #120285

Conversation

williamoconnorme
Copy link
Contributor

@williamoconnorme williamoconnorme commented Sep 20, 2023

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.5 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service
Copy link
Contributor

Hello @williamoconnorme,

The package manager bot determined there was an issue with one of the installers listed in the url field, and cannot continue.

The application included in this pull request failed to install during dynamic validation. This test is designed to ensure that the application installs on all environments without warnings. Please, verify that the application installs correctly on architectures specified in the manifest using winget cli.

Template: msftbot/validationError/installers/shellExecute

@williamoconnorme
Copy link
Contributor Author

@williamoconnorme please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Sep 20, 2023
@williamoconnorme
Copy link
Contributor Author

This PR is blocked due to the requirement of package Microsoft.ServiceFabricRuntime being installed before the SDK. When winget 1.6 introduces dependencies, I'll update this PR to the latest manifest schema

@stephengillie
Copy link
Collaborator

stephengillie commented Sep 20, 2023

Automatic Validation ended with:

Installation failed with exit code -1978335226
2023-09-20 08:05:56.271 [CLI ] ShellExecute installer failed: 1603 Property(S): ErrorDialog = ErrorDlg
MSI (s) (94:A4) [08:05:56:036]: Product: Microsoft Azure Service Fabric SDK -- Installation failed.
MSI (s) (94:A4) [08:05:56:036]: Windows Installer installed the product. Product Name: Microsoft Azure Service Fabric SDK. Product Version: 7.0.1816.9590. Product Language: 1033. Manufacturer: Microsoft Corporation. Installation success or error status: 1603.

Status 1603 often indicates a missing dependency, and Microsoft.ServiceFabricRuntime does appear to be the Microsoft Azure Service Fabric SDK.

@stephengillie stephengillie added Dependencies and removed Needs-Attention This work item needs to be reviewed by a member of the core team. labels Sep 20, 2023
@microsoft-github-policy-service
Copy link
Contributor

Hello @williamoconnorme,

This package appears to require dependencies in order to install successfully.

This PR is blocked until support for dependencies is implemented in:

Be sure to add your 👍 to the issue to help raise the priority and avoid posting "Me too!" messages to respect those who have subscribed to the issue.

Template: msftbot/blockingIssue/dependencySupport

@microsoft-github-policy-service microsoft-github-policy-service bot added Blocking-Issue Manifest validation is blocked by a known issue. Needs-Author-Feedback This needs a response from the author. labels Sep 20, 2023
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed Blocking-Issue Manifest validation is blocked by a known issue. Needs-Author-Feedback This needs a response from the author. Validation-Shell-Execute labels Sep 28, 2023
@wingetbot wingetbot added the Manifest-Validation-Error Manifest validation failed label Sep 28, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Sep 28, 2023
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed Manifest-Validation-Error Manifest validation failed Needs-Author-Feedback This needs a response from the author. labels Sep 28, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Sep 28, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the No-Recent-Activity No activity has occurred on this work item for seven days. label Oct 5, 2023
@microsoft-github-policy-service
Copy link
Contributor

Hello @williamoconnorme,

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment.

Template: msftbot/noRecentActivity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependencies Needs-Author-Feedback This needs a response from the author. No-Recent-Activity No activity has occurred on this work item for seven days. Validation-Shell-Execute
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants