Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Package: Soundux.Soundux version 0.2.7 #141520

Closed

Conversation

og-mrk
Copy link
Contributor

@og-mrk og-mrk commented Feb 29, 2024

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.6 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow

@og-mrk
Copy link
Contributor Author

og-mrk commented Feb 29, 2024

This PR should satisfy issue #58855

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided. label Feb 29, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Feb 29, 2024
@stephengillie
Copy link
Collaborator

stephengillie commented Feb 29, 2024

Automatic Validation ended with:
image

@og-mrk og-mrk force-pushed the update-manifest/Soundux.Soundux branch from 66389a0 to 463dc80 Compare March 1, 2024 08:47
@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided. Needs-Author-Feedback This needs a response from the author. labels Mar 1, 2024
@wingetbot wingetbot added the Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided. label Mar 1, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Mar 1, 2024
@stephengillie
Copy link
Collaborator

Automatic Validation ended with:

(Automated response - build 856.)

@stephengillie
Copy link
Collaborator

stephengillie commented Mar 1, 2024

Automatic Validation ended with:

2024-03-01 01:24:09.661 [REPO] Examining ARP entries for User | X64
2024-03-01 01:24:09.796 [CLI ] Installer args: /SILENT /NORESTART /LOG="C:\Users\validator\AppData\Local\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\DiagOutputDir\WinGet-Soundux.Soundux.0.2.7-2024-03-01-01-24-09.796.log" /NORESTART, /LOG
2024-03-01 01:24:09.800 [CLI ] Starting: 'C:\Users\VALIDA~1\AppData\Local\Temp\WinGet\Soundux.Soundux.0.2.7\soundux-0.2.7-windows-setup.exe' with arguments '/SILENT /NORESTART /LOG="C:\Users\validator\AppData\Local\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\DiagOutputDir\WinGet-Soundux.Soundux.0.2.7-2024-03-01-01-24-09.796.log" /NORESTART, /LOG'

@stephengillie
Copy link
Collaborator

stephengillie commented Mar 1, 2024

Hi @og-mrk

The installation is unattended, but installs a driver which isn't unattended:
image

Unfortunately, installer switches are not usually provided for this situation. Are you aware of an installer switch to have the driver silently install as well?

@og-mrk
Copy link
Contributor Author

og-mrk commented Mar 1, 2024

Hello @stephengillie

Sadly after reading through the Original Issue requesting this package, I've noticed that the same problem is happening over here, that being The Driver Installer isn't Silently Installing when Soundux is installing, the only possible way to install programs like this one is by using Dependency Resolution, a Feature that's still not fully supported by winget-cli (see this issue to see why).

Anyhow, my apologies for not checking before making this PR, hope I didn't waste much of Maintainer's time, thanks for the help as always, and have a nice day.


Note: I'm still hopeful to making this package install completely unattended, so I'll convert this PR to Draft for time been.

@og-mrk og-mrk marked this pull request as draft March 1, 2024 22:02
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Mar 1, 2024
@stephengillie stephengillie added the DriverInstall Package includes driver software that needs to be manually installed. label Mar 4, 2024
@og-mrk og-mrk force-pushed the update-manifest/Soundux.Soundux branch from 463dc80 to fc89d1f Compare March 9, 2024 17:25
@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed Needs-Attention This work item needs to be reviewed by a member of the core team. Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided. labels Mar 9, 2024
@wingetbot wingetbot added the Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided. label Mar 9, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Author-Feedback This needs a response from the author. No-Recent-Activity No activity has occurred on this work item for seven days. labels Mar 9, 2024
@og-mrk
Copy link
Contributor Author

og-mrk commented Mar 15, 2024

Like I've stated before, I'll look into this PR when Soundux have implemented an installer that is separate from the Driver Installer.

Which unfortunately, I don't really have a clear idea as to when this will happen.

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed No-Recent-Activity No activity has occurred on this work item for seven days. Needs-Author-Feedback This needs a response from the author. labels Mar 15, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added Blocking-Issue Manifest validation is blocked by a known issue. and removed Needs-Attention This work item needs to be reviewed by a member of the core team. labels Apr 18, 2024
@og-mrk og-mrk closed this Apr 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocking-Issue Manifest validation is blocked by a known issue. DriverInstall Package includes driver software that needs to be manually installed. Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants