Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New package: Opsfolio.Surveilr version 0.9.0 #155614

Closed
wants to merge 2 commits into from
Closed

New package: Opsfolio.Surveilr version 0.9.0 #155614

wants to merge 2 commits into from

Conversation

Lilit0x
Copy link

@Lilit0x Lilit0x commented May 29, 2024 •
edited by microsoft-github-policy-service bot
Loading

Checklist for Pull Requests

Manifests

  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.6 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Validation-Installation-Error Error installing application label May 29, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label May 29, 2024
@stephengillie
Copy link
Collaborator

Hi @Lilit0x,

The package didn't pass a Defender or similar security scan. This might be a false positive and we can rescan tomorrow.

(Automated response - build 881.)

@stephengillie
Copy link
Collaborator

Automatic Validation ended with:

Installation failed with exit code -1978335187
2024-05-29 15:20:10.767 [FAIL] Installer failed security check. Url: https://github.com/opsfolio/releases.opsfolio.com/releases/download/0.9.0/surveilr.exe Result: 0x80004005

Automated error analysis suggests -1978335187 may mean Installer failed security check. Another script should retry this every 18 hours.

(Automated response - build 881.)

@stephengillie stephengillie added the Needs-CLA The author needs to sign the CLA label May 29, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. Validation-Defender-Error labels May 29, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs-Author-Feedback This needs a response from the author. label May 29, 2024
@Lilit0x
Copy link
Author

Lilit0x commented May 29, 2024

@microsoft-github-policy-service agree company="Opsfolio"

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed Needs-Attention This work item needs to be reviewed by a member of the core team. Validation-Defender-Error Validation-Installation-Error Error installing application labels May 29, 2024
@wingetbot wingetbot added the Validation-Installation-Error Error installing application label May 29, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label May 29, 2024
@stephengillie
Copy link
Collaborator

stephengillie commented May 29, 2024 •
edited
Loading

Automatic Validation ended with:

Installation failed with exit code -1978335187
2024-05-29 12:53:01.666 [FAIL] Installer failed security check. Url: https://github.com/opsfolio/releases.opsfolio.com/releases/download/0.9.0/surveilr.exe Result: 0x80004005

Automated error analysis suggests -1978335187 may mean Installer failed security check. Another script should retry this every 18 hours.

(Automated response - build 881.)

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. Validation-Defender-Error labels May 29, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot removed Needs-Attention This work item needs to be reviewed by a member of the core team. Needs-Author-Feedback This needs a response from the author. Validation-Defender-Error Validation-Installation-Error Error installing application labels May 31, 2024
@wingetbot wingetbot added New-Package Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Executable-Error labels May 31, 2024
@stephengillie
Copy link
Collaborator

Automatic Validation ended with:

ADO Build not found.

(Automated response - build 886.)

@stephengillie stephengillie removed the Needs-CLA The author needs to sign the CLA label Jul 15, 2024
@stephengillie
Copy link
Collaborator

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Executable-Error labels Jul 15, 2024
@stephengillie
Copy link
Collaborator

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Executable-Error labels Jul 16, 2024
@stephengillie
Copy link
Collaborator

Automatic Validation ended with:

(Automated response - build 886.)

stephengillie
stephengillie requested changes Jul 17, 2024
View reviewed changes
Copy link
Collaborator

@stephengillie stephengillie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Lilit0x,

image

This appaers to be version 0.9.1. (The package manager adds the Registry entry for portable applications.)

manifests/o/Opsfolio/Surveilr/0.9.0/Opsfolio.Surveilr.installer.yaml
# yaml-language-server: $schema=https://aka.ms/winget-manifest.installer.1.6.0.schema.json

PackageIdentifier: Opsfolio.Surveilr
PackageVersion: 0.9.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
PackageVersion: 0.9.0
PackageVersion: 0.9.1

Please update file path to match this change.

manifests/o/Opsfolio/Surveilr/0.9.0/Opsfolio.Surveilr.locale.en-US.yaml
# yaml-language-server: $schema=https://aka.ms/winget-manifest.defaultLocale.1.6.0.schema.json

PackageIdentifier: Opsfolio.Surveilr
PackageVersion: 0.9.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
PackageVersion: 0.9.0
PackageVersion: 0.9.1

Please update file path to match this change.

manifests/o/Opsfolio/Surveilr/0.9.0/Opsfolio.Surveilr.yaml
# yaml-language-server: $schema=https://aka.ms/winget-manifest.version.1.6.0.schema.json

PackageIdentifier: Opsfolio.Surveilr
PackageVersion: 0.9.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
PackageVersion: 0.9.0
PackageVersion: 0.9.1

Please update file path to match this change.

@stephengillie stephengillie added the Needs-Author-Feedback This needs a response from the author. label Jul 17, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the No-Recent-Activity No activity has occurred on this work item for seven days. label Jul 22, 2024
@microsoft-github-policy-service Microsoft GitHub Policy Service
Copy link
Contributor

Hello @Lilit0x,

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any recent activity. It will be closed if no further activity occurs within 3 days of this comment.

Template: msftbot/noRecentActivity

auto-merge was automatically disabled July 25, 2024 08:31

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephengillie stephengillie stephengillie requested changes

Assignees

@Lilit0x Lilit0x

@stephengillie stephengillie

Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Changes-Requested Changes Requested Needs-Author-Feedback This needs a response from the author. New-Package No-Recent-Activity No activity has occurred on this work item for seven days. Validation-Completed Validation passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Lilit0x @wingetbot @stephengillie