Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DanielSchnabel.Chatterino version 2.3.2 #16896

Closed
wants to merge 1 commit into from
Closed

DanielSchnabel.Chatterino version 2.3.2 #16896

wants to merge 1 commit into from

Conversation

seriousm4x
Copy link
Contributor

@seriousm4x seriousm4x commented Jun 9, 2021

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.0 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided. label Jun 9, 2021
@ghost ghost assigned seriousm4x Jun 9, 2021
@ghost
Copy link

ghost commented Jun 9, 2021

Hello @seriousm4x,
During installation testing, this application failed to install without user input. Did you forget to add Silent or SilentWithProgress switches?

This can also happen when a dependency is missing. You can test with https://github.com/microsoft/winget-pkgs#test-your-manifest.

Please investigate a fix and resubmit the Pull Request.

You may also try using the Windows Package Manager Manifest Creator to determine the proper installer type. If the installer type is MSIX, MSI or a known installer technology like NullSoft, Inno, etc. the wingetcreate tool can detect then the winget client will know what switches to pass. If it's a .exe installer of an unknown type, you will need to search to determine the proper switches for Silent and SilentWithProgress.

@seriousm4x
Copy link
Contributor Author

During the installation a window for the C++ runtime pops up, where you can choose to install C++ runtime or just close the window if you already installed it.

This causes the validation to fail. How should that be handled?

@denelon
Copy link
Contributor

denelon commented Jun 9, 2021

@seriousm4x if you would prefer, we can label the PR with "Blocking-Issue" and "Dependency" to keep the work you've done on the manifest, When we implement those pesky, blocking issues, we will attempt to approve the PRs.

@seriousm4x
Copy link
Contributor Author

sounds good to me

@ghost ghost mentioned this pull request Jul 6, 2021
@ghost ghost closed this in #19938 Jul 6, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants