Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Here I tried to add the installer package for the C/C++ compiler MinG… #2938

Closed
wants to merge 1 commit into from
Closed

Conversation

ritchielrez
Copy link
Contributor

@ritchielrez ritchielrez commented Aug 6, 2020

…W, so everyone can download this package through Winget easily.

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • Have you validated your manifest locally with winget validate <manifest>, where <manifest> is the name of the manifest you're submitting?
  • Have you tested your manifest locally with winget install -m <manifest>?

Microsoft Reviewers: Open in CodeFlow

…W, so everyone can download this package through Winget easily.
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. label Aug 6, 2020
@ghost ghost assigned KevinLaMS Aug 6, 2020
@ghost
Copy link

ghost commented Aug 6, 2020

This submission has moved to manual review.

@ritchielrez
Copy link
Contributor Author

I hope this will turn out good. I've tried out my best.

Copy link

@RitchielRez1 RitchielRez1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

Copy link
Contributor Author

@ritchielrez ritchielrez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link

@RitchielRez1 RitchielRez1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful contribution!

InstallerType: EXE
Url: https://osdn.net/frs/redir.php?m=xtom_us&f=mingw%2F68260%2Fmingw-get-setup.exe
Sha256: a5de8c70676fdd157414e3116c7cb6f3dba48e549b5880177b10e4e6bc6c282e
# Generated by https://github.com/ptorr-msft/WinGetYamlGenerator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems a not a bad concept!

@RitchielRez1
Copy link

Wonderful contribution!

Approved!

@ghost
Copy link

ghost commented Aug 6, 2020

Greetings ritchielrez
During installation testing, this application failed to install with out user input. Did you forget to add Silent or SilentWithProgress switches?

Please investigate a fix and resubmit the Pull Request.

@ghost ghost added Needs: author feedback and removed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. labels Aug 6, 2020
@ghost ghost added the No-Recent-Activity No activity has occurred on this work item for seven days. label Aug 14, 2020
@ghost
Copy link

ghost commented Aug 14, 2020

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment.

@ritchielrez
Copy link
Contributor Author

I've tried to add Silent and SilentWithProgress switches but none of them worked for the setup.

@ghost ghost added Needs: Attention and removed Needs: author feedback No-Recent-Activity No activity has occurred on this work item for seven days. labels Aug 14, 2020
@KevinLaMS KevinLaMS added the Blocking-Issue Manifest validation is blocked by a known issue. label Oct 1, 2020
@denelon
Copy link
Contributor

denelon commented May 4, 2021

@ritchielrez I did some searching and I found a very old reference to a request to support a silent install for minGW.
https://sourceforge.net/p/mingw/bugs/2176/

I'm not sure if there is a way to provide a scripted install with default options applied or not. That issue is quite old.

We also don't have support for filtering or preferring silent install which is why we require silent in the community repository.
microsoft/winget-cli#910

Once that issue has been implemented, we may consider lifting that restriction. Users would be able to avoid interactive installers for their automated install processes like import.

@denelon
Copy link
Contributor

denelon commented May 4, 2021

The manifest schema has also changed. This needs to be updated to the v1.0 schema.

@ghost ghost added the No-Recent-Activity No activity has occurred on this work item for seven days. label May 11, 2021
@ghost
Copy link

ghost commented May 11, 2021

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment.

@ritchielrez
Copy link
Contributor Author

ritchielrez commented May 18, 2021

I don't use Windows anymore. If anyone can resolve this issue it would be a great contribution.

@ghost ghost added Needs: Attention and removed Needs: author feedback No-Recent-Activity No activity has occurred on this work item for seven days. labels May 18, 2021
@denelon denelon added the Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided. label Jul 14, 2022
@ghost
Copy link

ghost commented Jul 14, 2022

Hello @ritchielrez,
This package appears to require user interaction to complete. Please check to see if this package can be installed unattended, and modify the manifest.

Template: msftbot/validationError/installation/unattended

@ghost ghost added the Needs-Author-Feedback This needs a response from the author. label Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocking-Issue Manifest validation is blocked by a known issue. Needs-Author-Feedback This needs a response from the author. Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants